Skip to content

Remove old dimensioned Tensor annotations - #408

Merged
j-emberton merged 1 commit into
mainfrom
migration/remove-old-quantity-annotations
Nov 12, 2026
Merged

j-emberton merged 1 commit into
mainfrom
migration/remove-old-quantity-annotations

Conversation

@j-emberton

@j-emberton j-emberton commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Remove support for the old Annotated[Tensor, DIM] declaration now that the quantity annotation migration is on main.

Changes

  • Reject dimensioned Tensor annotations at system fields, equation parameters, transform parameters and return values, with an error pointing to the replacement API.
  • Keep Annotated[Quantity, DIM] for scalar quantities, Annotated[QuantityTensor, DIM] for tensor-only quantities, and Annotated[Quantity | QuantityTensor, DIM] for pointwise quantities.
  • Preserve exact Domain hints on pointwise equations, while rejecting tensor-domain requirements on scalar system fields.
  • Add focused regression tests for the removed API and invalid scalar-domain declarations.

Scope

This is the final API-removal step. Previous migrations of tests, benchmarks, documentation and worked examples are already merged. No migration changes are repeated here.

Validation

  • Rebases cleanly on current main as one commit, with three changed files.
  • GitHub reports the PR as mergeable.
  • Full CI is awaiting results on the rebased commit.

@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch from 39bdac4 to 437043c Compare November 9, 2026 12:07
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch from daad98f to 4b15143 Compare November 9, 2026 12:07
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch from 437043c to 4eaf01e Compare November 9, 2026 12:47
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch from 4b15143 to b45b7d7 Compare November 9, 2026 12:47
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch from 4eaf01e to 4c819f9 Compare November 9, 2026 12:52
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch from b45b7d7 to eef53d8 Compare November 9, 2026 12:52
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch from 4c819f9 to c476e99 Compare November 9, 2026 13:50
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch from eef53d8 to ab9b186 Compare November 9, 2026 13:50
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch from c476e99 to be2e2ae Compare November 10, 2026 07:47
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch from ab9b186 to ebf29ab Compare November 10, 2026 07:47
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch from be2e2ae to 7d0199e Compare November 10, 2026 07:57
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch from ebf29ab to 23a09fe Compare November 10, 2026 07:57
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch from 7d0199e to e5ba8e9 Compare November 10, 2026 08:06
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch from 23a09fe to e42e381 Compare November 10, 2026 08:06
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch from e5ba8e9 to db7343b Compare November 10, 2026 22:06
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch 2 times, most recently from 816b0e1 to bb967d1 Compare November 10, 2026 22:08
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch 7 times, most recently from 506338d to c81d8f0 Compare November 11, 2026 17:43
@j-emberton
j-emberton force-pushed the migration/quantity-api-worked-examples branch 5 times, most recently from 6b9c4fc to e70e705 Compare November 11, 2026 17:54
Base automatically changed from migration/quantity-api-worked-examples to main November 11, 2026 17:57
@j-emberton
j-emberton force-pushed the migration/remove-old-quantity-annotations branch from bb967d1 to bb4cb23 Compare November 12, 2026 20:04
@j-emberton
j-emberton marked this pull request as ready for review November 12, 2026 20:04
@j-emberton
j-emberton merged commit 24898a0 into main Nov 12, 2026
2 checks passed
@j-emberton
j-emberton deleted the migration/remove-old-quantity-annotations branch November 12, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant