Repository navigation
Remove old dimensioned Tensor annotations - #408
Merged
Merged
Conversation
This was referenced Nov 9, 2026
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
from
November 9, 2026 12:07
39bdac4 to
437043c
Compare
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
from
November 9, 2026 12:07
daad98f to
4b15143
Compare
This was referenced Nov 9, 2026
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
from
November 9, 2026 12:47
437043c to
4eaf01e
Compare
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
from
November 9, 2026 12:47
4b15143 to
b45b7d7
Compare
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
from
November 9, 2026 12:52
4eaf01e to
4c819f9
Compare
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
from
November 9, 2026 12:52
b45b7d7 to
eef53d8
Compare
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
from
November 9, 2026 13:50
4c819f9 to
c476e99
Compare
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
from
November 9, 2026 13:50
eef53d8 to
ab9b186
Compare
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
from
November 10, 2026 07:47
c476e99 to
be2e2ae
Compare
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
from
November 10, 2026 07:47
ab9b186 to
ebf29ab
Compare
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
from
November 10, 2026 07:57
be2e2ae to
7d0199e
Compare
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
from
November 10, 2026 07:57
ebf29ab to
23a09fe
Compare
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
from
November 10, 2026 08:06
7d0199e to
e5ba8e9
Compare
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
from
November 10, 2026 08:06
23a09fe to
e42e381
Compare
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
from
November 10, 2026 22:06
e5ba8e9 to
db7343b
Compare
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
2 times, most recently
from
November 10, 2026 22:08
816b0e1 to
bb967d1
Compare
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
7 times, most recently
from
November 11, 2026 17:43
506338d to
c81d8f0
Compare
j-emberton
force-pushed
the
migration/quantity-api-worked-examples
branch
5 times, most recently
from
November 11, 2026 17:54
6b9c4fc to
e70e705
Compare
Base automatically changed from
migration/quantity-api-worked-examples
to
main
November 11, 2026 17:57
j-emberton
force-pushed
the
migration/remove-old-quantity-annotations
branch
from
November 12, 2026 20:04
bb967d1 to
bb4cb23
Compare
j-emberton
marked this pull request as ready for review
November 12, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for the old
Annotated[Tensor, DIM]declaration now that the quantity annotation migration is onmain.Changes
Tensorannotations at system fields, equation parameters, transform parameters and return values, with an error pointing to the replacement API.Annotated[Quantity, DIM]for scalar quantities,Annotated[QuantityTensor, DIM]for tensor-only quantities, andAnnotated[Quantity | QuantityTensor, DIM]for pointwise quantities.Domainhints on pointwise equations, while rejecting tensor-domain requirements on scalar system fields.Scope
This is the final API-removal step. Previous migrations of tests, benchmarks, documentation and worked examples are already merged. No migration changes are repeated here.
Validation
mainas one commit, with three changed files.