avahi-test: do reverse lookups only when the corresponding lookups succeed - #107
Merged
Merged
Conversation
…cceed Fixes ``` + valgrind --track-origins=yes --exit-on-first-error=yes --error-exitcode=1 --leak-check=full --track-fds=yes /tmp/tmp.4MDJpCvVh1/avahi-test ipv6.local ==62957== Memcheck, a memory error detector ==62957== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al. ==62957== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info ==62957== Command: /tmp/tmp.4MDJpCvVh1/avahi-test ipv6.local ==62957== ==62957== Use of uninitialised value of size 8 ==62957== at 0x48C60BB: _itoa_word (_itoa.c:183) ==62957== by 0x48D0C9B: __printf_buffer (vfprintf-process-arg.c:155) ==62957== by 0x48EF991: __vsprintf_internal (iovsprintf.c:62) ==62957== by 0x499EE9E: __sprintf_chk (sprintf_chk.c:40) ==62957== by 0x49AACA9: sprintf (stdio2.h:30) ==62957== by 0x49AACA9: inet_ntop4 (inet_ntop.c:85) ==62957== by 0x49AACA9: inet_ntop (inet_ntop.c:57) ==62957== by 0x10A91F: avahi_resolve_address_with_socket (avahi.c:138) ==62957== by 0x10AB11: avahi_resolve_address (avahi.c:181) ==62957== by 0x10B85F: main (avahi-test.c:38) ==62957== Uninitialised value was created by a stack allocation ==62957== at 0x10B780: main (avahi-test.c:26) ==62957== ==62957== ==62957== Exit program on first error (--exit-on-first-error=yes) ``` Closes avahi#104
Collaborator
Author
|
The CI here is useless. I'll merge it once https://github.com/evverx/avahi/actions/runs/19606501739/job/56146109229?pr=3 is green and then start running the test under Valgrind in the avahi repository. |
evverx
added a commit
to avahi/avahi
that referenced
this pull request
Nov 23, 2025
Now that avahi/nss-mdns#107 is merged it should be fine to run it under Valgrind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Closes #104