Return notfound when lookup for the unhandled AF is tried - #101
Conversation
1ac4b6d to
1bafe40
Compare
|
I'm not sure how safe it is to make backward incompatible changes like this but if you are convinced that it's warranted (as opposed to, say, keeping that stuff intact, documenting the pitfalls and introducing new modules instead) I think the commit message should be more specific. I don't think "Fixes #100" is descriptive enough. It should probably say what exactly it fixes, why it does that and why the breaking change is warranted in general. Tests would be nice too. |
Changes return code for mdns4_minimal and mdns6_minimal, when request is done for the other address family. It behaves like that host is never found. That makes plugin to not continue to dns lookup only for single address family. It expects user would have return on not found. Just like is suggested in README.me /etc/nsswitch is expected to have: hosts: files mdns4_minimal [NOTFOUND=return] dns This change will stop resolving all AF_INET6 on mdns4_minimal. Because there is no configration file used for minimal variants, it does not have any way to return previous behaviour. It is expected new behaviour would be considered better by everyone. Fixes avahi#100
1bafe40 to
ed3155a
Compare
|
Hmm, when tried it on my host, it seems it returns ipv6 mapped ipv4 address to |
|
I didn't mean manual tests. If you are planning to enforce some sort of policy where IPv6 lookups can't get past the nss-mdns modules it should come with actual tests making sure that it actually works (and keeps working). It should be possible to bring the actual CI from avahi/avahi#768 and test all those things. Other than that I'm not sure why backward incompatible changes are needed. Why can't |
2 participants
Fixes #100