Fixing test script issues #138
Open
spoorthy13 wants to merge 2 commits into
Open
Conversation
Fixed: added general package version check function to tc_utils.source and changed the same in oddjob script signed-off by: Spoorthy<spoorts2@in.ibm.com>
kumudag
suggested changes
Apr 20, 2018
kumudag
left a comment
kumudag
left a comment
Contributor
There was a problem hiding this comment.
Add condition to check if samba is installed and only then run these sub-tests.
Fix: Excluded samba related tests when Samba package is not installed signed-off by:spoorthy<spoorts2@in.ibm.com>
spoorthy13
force-pushed
the
testbug_authconfig
branch
from
5e9bffa to
1b400c9
Compare
Contributor
Author
|
I have added the required changes to authconfig test script as suggested by Kumuda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.Bug Description: oddjob change pkgname var expression
Fix: added general package version check function to tc_utils.source and changed the same in oddjob script
Fix: Excluded samba related tests in authconfig test script
signed-off by:spoorthyspoorts2@in.ibm.com