1) Added new code under linux-tools , this code can be usefull for b… by abhipsnl · Pull Request #122 · autotest/autotest-client-tests

abhipsnl · 2017-08-03T11:04:18Z

…uilding packages under ubuntu OS.

Apart from this modified existing code based on previous commit comments .

New changes are given below
a) Changes from 'sh' to 'bash' in wrapper script
b) Propers comments on Wrapper script.
c) Handled return code properly for warning

NOTE : Previous pull request was failed , that too need to be merged

…ilding packages under ubuntu OS. 2) Apart from this modified existing code based on previous commit comments . New changes are given below a) Changes from 'sh' to 'bash' in wrapper script b) Propers comments on Wrapper script. c) Handled return code properly for warning

…he code to work on ubuntu

athira-rajeev · 2017-08-03T13:51:10Z

-	tc_exist_or_break /etc/prelink.conf /etc/sysconfig/prelink || return
+	#tc_exist_or_break /etc/prelink.conf /etc/sysconfig/prelink || return
+	tc_exist_or_break /etc/prelink.conf /usr/sbin/prelink || return



Please Correct Summary !

In tc_exec_or_break $REQUIRED prelink check is done.
And how about distros which has /etc/sysconfig/prelink ? This change has to be made generic to work in all the cases.

athira-rajeev · 2017-08-03T14:01:22Z

        && userlibdir=/usr/lib64/ && \
 		libdir=/lib64/
+	# On Ubuntu usrlib and lib paths are diff, so modified the code based on that
+	grep -i "ubuntu" /etc/*-release >/dev/null 2>&1


Below change is specific for x86_64 arch. but prelink is available for power as well.
Please modify this change to work on all archs.

athira-rajeev · 2017-08-03T14:02:49Z

-	tc_fail_if_bad $? "prelink failed on cycle1" || return
+
+	# cycle1lib1.so libs are not part of Ubuntu, so excluding this test
+	grep -i "ubuntu" /etc/*-release >/dev/null 2>&1


cycle1lib1.so libs are created for test purpose ? If so this cannot be built for ubuntu ?

kumudag · 2017-08-03T14:04:27Z

+##
+##         FILE: README.txt
+##
+##  DESCRIPTION:  This File contains the steps of build and test autotest tests for all Linux Destro


Replace Destro to Distribution , where ever mentioned

kumudag · 2017-08-03T14:09:49Z

+
+Supported Linux Destro : Redhat,Ubuntu,suse,CentOS
+        Supported Arch : Intel X86_64 and ia32
+                         IBM Power (ppc,ppc64,ppc64le,ppcnf)


Are you sure it builds for ppcnf?

kumudag · 2017-08-03T14:12:53Z

+
+1) Git clone the latest autotest and autotest-linux-tools
+2) Based on the arguments build the required packages and copy to autotest-linux-tools
+3) Run the Regression test.


Modify Step 2 autotest-linux-tools to autotest-client-tests/linux-tools
Step 3 has to be Run autotest-client-tests

kumudag · 2017-08-03T14:21:37Z

+curl
+checkpolicy
+cracklib
+git


Add all packages into input_file which has tests inside autotest and are identified for ubuntu

Based on the previous comments I have modified the code. NOTE : Previous 2 pull request failed due to build error, need merge those too

athira-rajeev · 2017-08-08T09:24:38Z

Abhishek,
For Travis CI build failure, job log shows "The command "inspekt lint" exited with 1."
So please check your code with "inspekt"

The objective of this script is to build the test binaries which are useful and needed by autotest-client-tests. Though this is a build tool ( not a testcase ) , while reviewing observed that script is not using any autotest framework code( for logging/executing commands ) . @lmr can we have this code under linux-tools ?

kumudag · 2017-08-08T05:27:44Z

+        if input_tag in SUPPORTED_DIST:  
+	    continue
+	else:
+            display_message_fn("This %s tag is currently Supported" %input_tag,"ERROR")


Correct the error message as "not supported"

kumudag · 2017-08-08T05:57:12Z

+
+
+#############################################
+# Check current destro


it has to be distro/distribution

kumudag · 2017-08-08T06:28:40Z

+
+
+class ubuntu_conf:
+    build_src_distribution = ['xenial']                                        				 # for rhel or suse mentioned the distribution name or distribution version rhel7.4 for building


In a single run tests can be built for only one release , so make this var as a single one instead of list

kumudag · 2017-08-08T06:29:39Z

+# Module to check given release is supported or not
+######################################################
+def verify_distro_release_fn():
+    for input_tag in SRC_DIST:


for loop is not requried as the tool doesn't support multiple release builds in one run

kumudag · 2017-08-08T07:21:47Z

+    logdir = "%s/logs" %basedir
+    logfile = "%s/final_report.logs" %logdir
+    package_list_file = "/home/ubuntu/autotest-build-tools/input_file"   			           	 # This file will contain the package name to be build
+    binary_src_dir = "%s/autotest-binaries" %basedir								 # All the compile binaries will be copied in this location, you can change based on your requirement


good to include the build_src_distribution in the DIR structure as we can easily differentiate the builds based on versions.

kumudag · 2017-08-08T10:10:02Z

+    display_message_fn("Updating %s entries on %s file"%(l_distro_type,REPO_FILE),"INFO")
+    copy_status = os.system("sudo cp %s %s_bkp "%(REPO_FILE,REPO_FILE))
+    if copy_status != 0:
+        display_message_fn("Failed wahile taking the backup of %s file"%REPO_FILE,"ERROR")


s/wahile/while

kumudag · 2017-08-08T10:11:08Z

+#########################################################################
+# Module to revert back all the system changes one the task is finished
+#########################################################################
+def revert_back_changes_fn():


This function is not required?
function call has been commented below!

kumudag · 2017-08-08T10:16:11Z

+    	tc_register "passwd --warning"
+    	passwd --warning=9 $TC_TEMP_USER 1>$stdout 2>$stderr
+    	tc_pass_or_fail $? "settings to warn user before 9 days of password expiration failed"
+    fi


In ubuntu, passwd has different option for all above tests
-x, --maxdays MAX_DAYS
-n, --mindays MIN_DAYS
-w, --warndays WARN_DAYS

They have to be handled for ubuntu as well

kumudag · 2017-08-08T10:18:35Z

+	#Force to unlock user password which is empty
+    	tc_register "passwd --force"
+    	passwd --unlock --force $TC_TEMP_USER 1>$stdout 2>$stderr
+    	tc_pass_or_fail $? "Failed to force unlock passwd for $TC_TEMP_USER"


I see --keep-tokens option on ubuntu zesty, why it should not be executed here?

kumudag · 2017-08-08T10:21:06Z

 {
 pushd $PATCHUTILS_TESTS_DIR >$stdout 2>$stderr
-TST_TOTAL=`ls tests -I common.sh -I soak-test | wc -l`
+grep -i "ubuntu" /etc/*-release >/dev/null 2>&1


"grep -i "ubuntu" /etc/*-release" is being called multiple times in multiple scripts
declare DISTRO in a shared function and use it all over here

abhipsnl added 2 commits August 3, 2017 16:22

1 ) Libs and user libs path were are different in Ubuntu, modified t…

00d1c99

…he code to work on ubuntu

athira-rajeev reviewed Aug 3, 2017

View reviewed changes

kumudag reviewed Aug 3, 2017

View reviewed changes

Patch [ 2 ]

e2f13de

Based on the previous comments I have modified the code. NOTE : Previous 2 pull request failed due to build error, need merge those too

kumudag reviewed Aug 8, 2017

View reviewed changes



		#############################################
		# Check current destro



		class ubuntu_conf:
		build_src_distribution = ['xenial'] # for rhel or suse mentioned the distribution name or distribution version rhel7.4 for building

Conversation

abhipsnl commented Aug 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

athira-rajeev commented Aug 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants