Traceroute: Fix test to set time delay between probes.#104
Open
basheerk wants to merge 1 commit into
Open
Conversation
…ning because of the some drop in the probe packets.Small delay needs to added between the two tests, then these drop of probe packets doesn't exist and we get the expected the output in the stdout.
lmr
reviewed
Jun 1, 2017
lmr
left a comment
lmr
left a comment
Member
There was a problem hiding this comment.
Let us know if you can avoid adding a flat sleep here. Otherwise, I suppose this is fine.
| # If this is the only test that passes for a system, then we can guess | ||
| # that there is some system in the probe path that expects some delay | ||
| # between probes | ||
| sleep 05 |
Member
There was a problem hiding this comment.
In general, if you can add a waiting function for a certain system condition, that's always better than a flat sleep. Can you do that in this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traceroute test to set time delay between probes failed,This is happening
because of the some drop in the probe packets.Small delay needs to added
between the two tests, then these drop of probe packets doesn't exist
and we get the expected the output in the stdout.
signed-off-by: Basheer Kbasheer@linux.vnet.ibm.com