fix: add list coercion for direction/include_attributes in traverse_lineage_tool#217
Open
mothership-ai[bot] wants to merge 1 commit intomainfrom
Open
fix: add list coercion for direction/include_attributes in traverse_lineage_tool#217mothership-ai[bot] wants to merge 1 commit intomainfrom
mothership-ai[bot] wants to merge 1 commit intomainfrom
Conversation
…ineage_tool LLMs naturally pass direction and include_attributes as JSON lists (e.g. ["upstream"]) but the schema expects strings. This caused ~50 validation errors per 30 days. - If direction is a single-element list, extract the value - If direction is a multi-element list, return a helpful error - If include_attributes is a string, coerce it through parse_list_parameter - Catch AttributeError alongside KeyError for non-string direction values Closes AICHAT-829 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session owner: @abhinavmathur-atlan
Summary
directionparameter intraverse_lineage_tool— if LLMs pass["upstream"]instead of"upstream", extract the single element; if multiple values, return a helpful errorinclude_attributes— if LLMs pass a plain string instead of a list, coerce it throughparse_list_parameterAttributeErroralongsideKeyErrorin direction parsing to handle non-string types gracefullyContext
LLMs naturally produce JSON lists for these parameters (~50 validation errors/30d). This adds defensive coercion at the tool entry point without changing the underlying
traverse_lineagefunction.Closes AICHAT-829
Test plan
direction="UPSTREAM"still works (string passthrough)direction=["upstream"]is coerced to"upstream"direction=["upstream", "downstream"]raises a clear ValueErrorinclude_attributes="name"is coerced to["name"]include_attributes=["name", "description"]still works🤖 Generated with Claude Code