feat: Add Data Domain Retrieval Functionality#147
Open
christopher-tin-atlan wants to merge 2 commits intomainfrom
Open
feat: Add Data Domain Retrieval Functionality#147christopher-tin-atlan wants to merge 2 commits intomainfrom
christopher-tin-atlan wants to merge 2 commits intomainfrom
Conversation
- Replace manual attribute mapping with domain.dict() + relationship enrichment - Eliminate 20+ hardcoded attributes achieving 70% code reduction - Add PyAtlan nested attribute flattening for clean output structure - Maintain full relationship enrichment with simplified architecture - Future-proof: automatically includes new PyAtlan domain attributes - Update comprehensive docstrings for both function and MCP tool - Remove unused imports and test code for production readiness - Improve performance with simplified search setup This hybrid approach dramatically simplifies domain attribute handling while maintaining full functionality and eliminating manual maintenance overhead.
Hk669
requested changes
Sep 16, 2025
Comment on lines
+181
to
+188
| search = FluentSearch() | ||
| search = search.where(CompoundQuery.asset_type(DataDomain)) | ||
|
|
||
| if guid: | ||
| logger.debug(f"Searching for domain by GUID: {guid}") | ||
| search = search.where(Asset.GUID.eq(guid)) | ||
| else: | ||
| logger.debug(f"Searching for domain by qualified name: {qualified_name}") |
Collaborator
There was a problem hiding this comment.
instead of a tool, lets add the examples to search_assets_tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive data domain retrieval capabilities to the Atlan MCP server, enabling AI agents to fetch detailed domain information including hierarchical relationships and stakeholder data within a single API call.
This is a significant improvement over the current asset and lineage tool, as the MCP will provide an optimized alternative.
What's New
Comprehensive Data Return
Response Structure