Skip to content

Patch cmakelists to find a Lua version < 5.5 - #170

Merged
AstroBarker merged 1 commit into
mainfrom
blb/cmake_lua
May 1, 2026
Merged

Patch cmakelists to find a Lua version < 5.5#170
AstroBarker merged 1 commit into
mainfrom
blb/cmake_lua

Conversation

@AstroBarker

Copy link
Copy Markdown
Member

PR Summary

Sol2 does not yet work with Lua5.5 (ThePhD/sol2#1723). cmake's find_package supports version ranges but this never worked for me for Lua. This PR hacks in a range feature for Lua by walking backwards from 5.4 until a version of Lua is found. Also added link time optimizations.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by calling scripts/bash/format.sh.
  • Explain what you did.
  • Make any necessary changes to the documentation.
  • Update CHANGELOG.md
  • If any part of this contribution was made with generative AI assistance please include an AI usage disclosure following our AI Policy.

@AstroBarker
AstroBarker merged commit ff96c1a into main May 1, 2026
12 checks passed
@AstroBarker
AstroBarker deleted the blb/cmake_lua branch May 1, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant