Repository navigation
cache actortype label in CommonLabels - #1328
Open
brevin-yoke wants to merge 1 commit into
Open
brevin-yoke wants to merge 1 commit into
brevin-yoke wants to merge 1 commit into
Conversation
CommonLabels computed the actor type label on every metric emission via
fmt.Sprintf("%T", ...) followed by strings.Replace, incurring reflection
and string allocations on a hot path.
Since the label value is constant per concrete actor type, cache it in a
sync.Map keyed by reflect.Type and compute it only once per type. Use
reflect.TypeOf(...).String() in place of fmt.Sprintf to produce the same
output, and guard against a nil actor to preserve the previous "<nil>"
behavior.
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommonLabels computed the actor type label on every metric emission via
fmt.Sprintf("%T", ...) followed by strings.Replace, incurring reflection
and string allocations on a hot path.
Since the label value is constant per concrete actor type, cache it in a
sync.Map keyed by reflect.Type and compute it only once per type. Use
reflect.TypeOf(...).String() in place of fmt.Sprintf to produce the same
output, and guard against a nil actor to preserve the previous ""
behavior.