fix(ui): resolve Copilot PR reviews for newsletter and loader contrast#5408
fix(ui): resolve Copilot PR reviews for newsletter and loader contrast#5408sammy200-ui wants to merge 2 commits into
Conversation
sammy200-ui
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg,
princerajpoot20 and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughLoader text now supports Tailwind dark mode ( ChangesDark Mode Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Pull request overview
This PR addresses dark-theme visibility issues in UI components, specifically improving contrast for the Newsletter subscription section on the TSC page and ensuring loader text remains readable in dark mode.
Changes:
- Updated
pages/community/tsc.tsxto use thedarkprop onNewsletterSubscribeand reformatted inline gradient styles. - Updated
components/Loader.tsxto applydark:text-whiteso loader text remains visible when the site is in dark mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pages/community/tsc.tsx |
Switches TSC newsletter section to NewsletterSubscribe dark and reformats gradient style objects. |
components/Loader.tsx |
Ensures loader text switches to white under Tailwind dark mode when dark={false}. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <NewsletterSubscribe | ||
| type='TSC Voting' | ||
| title='Get notified when TSC is voting' | ||
| subtitle="You'll receive an email whenever someone requests the TSC to vote" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## website-ui #5408 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 22 22
Lines 830 830
Branches 159 159
============================================
Hits 830 830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sammy200-ui
force-pushed
the
website-ui-newsletter-copilot-fixes
branch
from
5220f20 to
321ea2a
Compare
sammy200-ui
force-pushed
the
website-ui-newsletter-copilot-fixes
branch
from
321ea2a to
f7240cc
Compare
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
| title='Get notified when TSC is voting' | ||
| subtitle="You'll receive an email whenever someone requests the TSC to vote" | ||
| className='text-white' | ||
| className='text-center' |
| <div className={twMerge(`w-fit flex gap-4 m-auto items-center ${pulsating ? 'animate-pulse ' : ''} ${className}`)}> | ||
| {loaderIcon} | ||
| <div className={`my-2 ${dark ? 'text-white' : 'text-black'}`}>{loaderText}</div> | ||
| <div className={`my-2 ${dark ? 'text-white' : 'text-black dark:text-white'}`}>{loaderText}</div> |
Issue was that the text was black
The loader was not visible
ref : #5399 (comment)
Summary by CodeRabbit