refactor: use exported filterIssues function in GoodFirstIssues#5404
refactor: use exported filterIssues function in GoodFirstIssues#5404nguyenquockhang1610 wants to merge 1 commit into
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR refactors GoodFirstIssues to delegate filtering to the exported filterIssues function, which now uses the literal 'All' sentinel and progressively narrows results based on selected repo and area. ChangesFilter Function Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5404--asyncapi-website.netlify.app/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5404 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 830 830
Branches 159 159
=========================================
Hits 830 830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3db2e84 to
7c28957
Compare
…nent - Fix filterIssues to check 'All' instead of 'Repository - All'/'Area - All' to match actual state values used in the component - Refactor component to use the exported filterIssues function instead of inline filtering logic - Removes code duplication Fixes asyncapi#4889
7c28957 to
8e984af
Compare
|



Summary
Refactors GoodFirstIssues component to use the exported
filterIssuesfunction instead of duplicated inline logic (#4889).Changes
filterIssuescomparison values fromRepository - All/Area - AlltoAll(matching actual state values)filterIssues(issues, { selectedRepo, selectedArea })Fixes #4889
Summary by CodeRabbit