Skip to content

fix: the lint issue and solved the ci pipeline #5386

Merged
princerajpoot20 merged 2 commits into
asyncapi:website-uifrom
Sourya07:fix/lint
May 10, 2026
Merged

fix: the lint issue and solved the ci pipeline #5386
princerajpoot20 merged 2 commits into
asyncapi:website-uifrom
Sourya07:fix/lint

Conversation

@Sourya07
Copy link
Copy Markdown
Contributor

@Sourya07 Sourya07 commented May 7, 2026

fixes -> #5253 (comment)

  • ...
  • ...
  • ...

Related issue(s)

Summary by CodeRabbit

  • Refactor
    • Consolidated repeated styling and toggle behavior in the mobile navigation for simpler, more maintainable code while preserving visuals and behavior.
  • Style
    • Cleaned up string composition in the Code Generation tab and restructured badge markup in Documentation; no visible label or output changes.

Review Change Stack

Review Change Stack

@netlify
Copy link
Copy Markdown

netlify Bot commented May 7, 2026

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ac9920
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/69fee5eef14f0e00081140a3
😎 Deploy Preview https://deploy-preview-5386--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 65cf4b43-c084-4035-9e0c-f3404041fe3e

📥 Commits

Reviewing files that changed from the base of the PR and between 2af50b8 and 0ac9920.

📒 Files selected for processing (2)
  • components/SneakPeek.tsx
  • components/navigation/MobileNavMenu.tsx

📝 Walkthrough

Walkthrough

Refactors SneakPeek JSX to replace inline template/string expressions with block-bodied rendering and multi-node JSX; centralizes repeated Tailwind class strings in MobileNavMenu into local constants and applies them to toggles, Others links, and Language items.

Changes

SneakPeek Component JSX Refactoring

Layer / File(s) Summary
Generation code render change
components/SneakPeek.tsx
renderGenerationCode changed to block-bodied function that builds logStatement via String.raw and uses it in the console.log argument.
Documentation badge JSX split
components/SneakPeek.tsx
email badge markup split across multiple JSX nodes with whitespace/newlines; rendered label unchanged.

MobileNavMenu Tailwind Class Consolidation

Layer / File(s) Summary
Shared Tailwind constants
components/navigation/MobileNavMenu.tsx
Adds local constants for section toggle, Others link/hover, and language button/hover Tailwind class strings.
Toggle button applications
components/navigation/MobileNavMenu.tsx
Docs, Tools, Community, Others, and Language toggle buttons now compose className from shared toggle constant and conditionally include rotate-180 when open; Others link mapping simplified.
Language menu item styling
components/navigation/MobileNavMenu.tsx
Per-language menu item button className composes shared language base/hover classes while preserving active/inactive styling logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I nibble strings into tidy nodes,

log lines arranged in gentle rows,
classes gathered into one small stack,
toggles spin with a tiny clack,
now I hop off to dream in code.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'lint issue' and 'ci pipeline', but the actual changes are refactoring and code organization improvements in SneakPeek.tsx and MobileNavMenu.tsx with no apparent linting fixes or CI pipeline modifications. Update the title to accurately reflect the main changes, such as 'refactor: organize Tailwind classes in navigation and code generation components' or 'refactor: extract and reuse Tailwind class constants in UI components'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sourya07 Sourya07 changed the title fixes the lint issue and solved the ci pipeline fix: the lint issue and solved the ci pipeline May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (website-ui@7c2813c). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             website-ui     #5386   +/-   ##
==============================================
  Coverage              ?   100.00%           
==============================================
  Files                 ?        22           
  Lines                 ?       830           
  Branches              ?       159           
==============================================
  Hits                  ?       830           
  Misses                ?         0           
  Partials              ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Sourya07
Copy link
Copy Markdown
Contributor Author

Sourya07 commented May 7, 2026

@princerajpoot20 please take a look

@princerajpoot20
Copy link
Copy Markdown
Member

@coderabbitai review this

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Tip

For best results, initiate chat on the files or code changes.

@princerajpoot20 Sure! I'll review the changes in this PR right away.

[review]

@Sourya07
Copy link
Copy Markdown
Contributor Author

Sourya07 commented May 7, 2026

@coderabbitai review this

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Tip

For best results, initiate chat on the files or code changes.

@Sourya07 Sure! I'll review the changes in this PR right away.

[review]

@Sourya07
Copy link
Copy Markdown
Contributor Author

Sourya07 commented May 9, 2026

@princerajpoot20 please verify this

@princerajpoot20
Copy link
Copy Markdown
Member

LGTM

@princerajpoot20
Copy link
Copy Markdown
Member

princerajpoot20 commented May 9, 2026

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

@princerajpoot20 Sure! I'll redo the full review of the changes in this PR right away.

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

✅ Actions performed

Full review triggered.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@components/SneakPeek.tsx`:
- Around line 166-176: The JSX fragments split a single template string into
many nodes (the console.log using message.displayName), hurting readability;
replace the fragments by computing a single string (e.g., create a constant like
logStatement = `Processing signup for ${message.displayName}`) and render it as
one span/JSX node (the span currently using className 'text-teal-200') or, if a
lint rule forces this, add a targeted eslint-disable comment with an explanation
above the single-node span; update the console.log rendering to use that single
variable and keep references to console.log and message.displayName intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6008c41a-ffb2-4187-ad0d-c2ce7a84e758

📥 Commits

Reviewing files that changed from the base of the PR and between 2af50b8 and 4f954ba.

📒 Files selected for processing (2)
  • components/SneakPeek.tsx
  • components/navigation/MobileNavMenu.tsx

Comment thread components/SneakPeek.tsx Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

@Sourya07
Copy link
Copy Markdown
Contributor Author

Sourya07 commented May 9, 2026

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

✅ Actions performed

Full review triggered.

@Sourya07
Copy link
Copy Markdown
Contributor Author

Sourya07 commented May 9, 2026

@princerajpoot20 take a look

@princerajpoot20
Copy link
Copy Markdown
Member

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 10, 2026

✅ Actions performed

Full review triggered.

@princerajpoot20 princerajpoot20 merged commit 714f545 into asyncapi:website-ui May 10, 2026
27 of 31 checks passed
@github-project-automation github-project-automation Bot moved this from To Be Triaged to Done in Website - Kanban May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants