fix: the rendering issue in the website-ui for the navbar#5376
Conversation
Sourya07
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
derberg,
princerajpoot20 and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughBoth ChangesScroll Handler Debouncing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Sourya07
changed the title
|
As discussed -> #5253 (comment) |
|
|
Hi @princerajpoot20, could you please take a look? I’ve fixed the rendering issue. |
|
Great stuff @Sourya07 , one suggestion - can you have it like before and after comparison in the description of the pr , so its much easier for maintainers to check and merge |
got it . |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
components/navigation/NavBar.tsx (1)
172-174: ⚡ Quick winRemove the commented-out code and stale JSX comment.
Lines 172–174 contain an old commented-out
<div>with its full className, and line 284 has a leftover{/* </div> */}comment. Both are dead code that add noise and can mislead future reviewers about the intended structure.🧹 Proposed cleanup
- {/* <div - className={`bg-white/60 mx-auto fixed flex left-0 right-0 top-0 w-full z-[12] items-center justify-between max-w-[76rem] select-none transition-all duration-300 ease-spring ring-1 ring-black/5 bg-white/76 backdrop-blur-lg shadow-lg lg:rounded-full lg:mt-3 translate-y-0 ${className} z-50`} - ></div> */}- {/* </div> */}Also applies to: 284-284
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/navigation/NavBar.tsx` around lines 172 - 174, Remove the dead commented JSX in the NavBar component: delete the commented-out <div> block containing the big className string and also remove the stray JSX comment token "{/* </div> */}" that closes it; ensure the component JSX structure remains balanced after removal (check NavBar's render/return and surrounding elements) and run a quick lint/format to confirm no leftover comment artifacts remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@components/navigation/NavBar.tsx`:
- Around line 172-174: Remove the dead commented JSX in the NavBar component:
delete the commented-out <div> block containing the big className string and
also remove the stray JSX comment token "{/* </div> */}" that closes it; ensure
the component JSX structure remains balanced after removal (check NavBar's
render/return and surrounding elements) and run a quick lint/format to confirm
no leftover comment artifacts remain.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2f4be283-bbb5-4b90-90ff-0c325872bc46
📒 Files selected for processing (2)
components/navigation/NavBar.tsxcomponents/navigation/StickyNavbar.tsx
princerajpoot20
left a comment
princerajpoot20
left a comment
There was a problem hiding this comment.
@Sourya07 Thanks for your effort.
Please go ahead and pick other remaining bugs.
|
@princerajpoot20 thanks |
@Sourya07 If they are few and manageable, like within the same file (the one you’re making changes to), then we can include them. If there are many such occurrences, we can handle those later in a single PR. Otherwise, the review may become slightly challenging. |
|
@princerajpoot20 solving the linting issue |
@Sourya07 Solving linting issues is our last priority for now. Focus on bugs first. |
|
okay |
3 participants
Description
Fixed a rendering issue where the UI was flickering due to incorrect state handling.
Changes
Before
Screen.Recording.2026-05-03.at.12.32.04.AM.mov
After
Screen.Recording.2026-05-03.at.11.46.33.AM.mov
Related issue(s)
Summary by CodeRabbit