Skip to content

fix: update broken link to removed workflow file in blog post#5360

Open
yifanyifan897645 wants to merge 2 commits into
asyncapi:masterfrom
yifanyifan897645:fix/broken-link-4970
Open

fix: update broken link to removed workflow file in blog post#5360
yifanyifan897645 wants to merge 2 commits into
asyncapi:masterfrom
yifanyifan897645:fix/broken-link-4970

Conversation

@yifanyifan897645
Copy link
Copy Markdown

@yifanyifan897645 yifanyifan897645 commented Apr 23, 2026

Summary

  • Fixed broken link in the "Shai Hulud postmortem" blog post
  • The auto-changeset.yml workflow was removed in PR ci: attempt at hardening security issue cli#1909, causing a 404
  • Replaced the dead master branch link with a permalink to the last commit before removal (6729f4c) so readers can still view the original file

Fixes #4970

Summary by CodeRabbit

  • Refactor

    • Streamlined internal filtering logic and improved code maintainability.
  • Documentation

    • Updated postmortem documentation with permanent, stable references.

yifan and others added 2 commits April 24, 2026 06:18
The exported filterIssues function was defined but never used, while the
component duplicated its logic inline with inconsistent filter values
('Repository - All' vs 'All'). Fix the filter values to match the
component's usage and replace inline logic with a filterIssues call.

Closes asyncapi#4889

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The auto-changeset.yml workflow was removed in PR asyncapi#1909. Replace the
dead master-branch link with a permalink to the last commit before
removal so readers can still see the original file.

Fixes asyncapi#4970

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 23, 2026

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f337ca2
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/69ea9cbbc8afde0008757292
😎 Deploy Preview https://deploy-preview-5360--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6464882a-a6af-4a8a-b12f-ec0c8b87d017

📥 Commits

Reviewing files that changed from the base of the PR and between 86f23d2 and f337ca2.

📒 Files selected for processing (2)
  • components/dashboard/GoodFirstIssues.tsx
  • markdown/blog/shai-hulud-postmortem.md

📝 Walkthrough

Walkthrough

Two files updated: GoodFirstIssues component refactored to consolidate filtering logic using a unified 'All' sentinel value, and a blog post link corrected to reference a fixed commit SHA instead of the moving master branch.

Changes

Cohort / File(s) Summary
Filtering Logic Consolidation
components/dashboard/GoodFirstIssues.tsx
Refactored to replace hardcoded sentinel values ('Repository - All', 'Area - All') with unified 'All' sentinel. Eliminated duplicated inline filtering logic by leveraging shared filterIssues helper. Simplified Filters props to pass original issues array directly. Removed JSDoc comments.
Blog Post Link Fix
markdown/blog/shai-hulud-postmortem.md
Updated GitHub Actions workflow URL from moving master branch reference to fixed commit SHA, resolving broken link that previously returned 404 error.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop and a bound, the filters align,
With 'All' as one sentinel, logic so fine!
Old links now point true, no 404 fright,
Code cleaned and refactored, everything bright! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 5

❌ Failed checks (4 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title accurately describes the primary change: fixing a broken link in the blog post. However, it only addresses one of two commits in this PR; the other commit refactors filtering logic in GoodFirstIssues.tsx. Either retitle to reflect both changes (e.g., 'refactor: consolidate filtering logic and fix broken link in blog post') or separate into two PRs.
Linked Issues check ⚠️ Warning The PR fulfills the requirement from issue #4970 by updating the broken link to a permalink referencing commit 6729f4c before removal. However, the refactoring commit to GoodFirstIssues.tsx addresses issue #4889, which is not listed in the linked issues. Ensure all linked issues associated with code changes are documented. Add #4889 to the linked issues if not already present.
Out of Scope Changes check ⚠️ Warning The refactoring of GoodFirstIssues.tsx appears unrelated to the primary objective of fixing the broken workflow link in the blog post. Consider separating the GoodFirstIssues.tsx refactoring into a separate PR to maintain focused, single-purpose changesets.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description field was provided in the PR context for validation. Provide the pull request description to validate completeness and clarity of the change explanation.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (86f23d2) to head (f337ca2).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #5360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          830       830           
  Branches       159       159           
=========================================
  Hits           830       830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asyncapi-bot
Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-5360--asyncapi-website.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Be Triaged

Development

Successfully merging this pull request may close these issues.

[BUG] :Broken link: “workflow with unsecured context” points to missing GitHub Actions workflow

2 participants