-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: enchanced the look of the clickable logos from non clickable in the home page #5320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,26 +1,15 @@ | ||||||||||||
| import React, { useState } from 'react'; | ||||||||||||
| import React from 'react'; | ||||||||||||
|
|
||||||||||||
| /** | ||||||||||||
| * @description Logo for SAP | ||||||||||||
| * @param {string} className - used to style the svg | ||||||||||||
| */ | ||||||||||||
| export default function SapLogo({ className }: { className?: string }) { | ||||||||||||
| const [isHovered, setIsHovered] = useState(false); | ||||||||||||
|
|
||||||||||||
| const handleMouseEnter = () => { | ||||||||||||
| setIsHovered(true); | ||||||||||||
| }; | ||||||||||||
| const handleMouseLeave = () => { | ||||||||||||
| setIsHovered(false); | ||||||||||||
| }; | ||||||||||||
|
|
||||||||||||
| return ( | ||||||||||||
| <svg | ||||||||||||
| className={className || 'inline-block'} | ||||||||||||
| fill='currentColor' | ||||||||||||
| viewBox='0 0 1024 522' | ||||||||||||
|
Comment on lines
9
to
12
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix Prettier formatting to unblock CI. The pipeline is failing due to multi-line prop formatting. Reformat the SVG opening tag to satisfy Prettier. 🔧 Suggested fix- <svg
- className={className || 'inline-block'}
- fill='currentColor'
- viewBox='0 0 1024 522'
- >
+ <svg className={className || 'inline-block'} fill='currentColor' viewBox='0 0 1024 522'>📝 Committable suggestion
Suggested change
🧰 Tools🪛 GitHub Actions: PR testing - if Node project[error] 9-9: ESLint (prettier/prettier): Prettier formatting error. Replace multi-line 🤖 Prompt for AI Agents |
||||||||||||
| onMouseEnter={handleMouseEnter} | ||||||||||||
| onMouseLeave={handleMouseLeave} | ||||||||||||
| > | ||||||||||||
| <linearGradient | ||||||||||||
| id='path3060_1_' | ||||||||||||
|
|
@@ -31,8 +20,8 @@ export default function SapLogo({ className }: { className?: string }) { | |||||||||||
| y2='661.6777' | ||||||||||||
| gradientTransform='matrix(0 513.7015 -513.7015 0 340415.5625 65474.9453)' | ||||||||||||
| > | ||||||||||||
| <stop offset='0' style={{ stopColor: isHovered ? '#1661BE' : 'currentColor' }} /> | ||||||||||||
| <stop offset='1' style={{ stopColor: isHovered ? '#019CE0' : 'currentColor' }} /> | ||||||||||||
| <stop offset='0' style={{ stopColor: 'currentColor' }} /> | ||||||||||||
| <stop offset='1' style={{ stopColor: 'currentColor' }} /> | ||||||||||||
| </linearGradient> | ||||||||||||
| <path | ||||||||||||
| id='path3060' | ||||||||||||
|
|
||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -13,7 +13,7 @@ interface SponsorImageProps { | |||||||||||||||||||
| export default function SponsorImage({ src, alt = 'Sponsor logo', className }: SponsorImageProps) { | ||||||||||||||||||||
| return ( | ||||||||||||||||||||
| <div className='flex size-full items-center justify-center'> | ||||||||||||||||||||
| <img src={src} alt={alt} className={twMerge('max-h-9 sm:max-h-12 w-auto object-contain', className)} /> | ||||||||||||||||||||
| <img src={src} alt={alt} className={twMerge('max-h-9 sm:max-h-12 w-auto object-contain group-hover:scale-110 group-hover:brightness-110 transition-all duration-300', className)} /> | ||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the Prettier failure on the Line 16 is failing lint formatting in CI; reformat this element to multiline JSX. 💡 Suggested formatting patch- <img src={src} alt={alt} className={twMerge('max-h-9 sm:max-h-12 w-auto object-contain group-hover:scale-110 group-hover:brightness-110 transition-all duration-300', className)} />
+ <img
+ src={src}
+ alt={alt}
+ className={twMerge(
+ 'max-h-9 sm:max-h-12 w-auto object-contain group-hover:scale-110 group-hover:brightness-110 transition-all duration-300',
+ className
+ )}
+ />📝 Committable suggestion
Suggested change
🧰 Tools🪛 GitHub Actions: PR testing - if Node project[error] 16-16: ESLint (prettier/prettier): Prettier formatting error. Replace the inline JSX 🤖 Prompt for AI Agents |
||||||||||||||||||||
| </div> | ||||||||||||||||||||
| ); | ||||||||||||||||||||
| } | ||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix Prettier-blocking JSX formatting on image tags.
The pipeline is failing at Line 33, Line 48, and Line 63 due to inline
<img>formatting. Please apply multiline JSX formatting to unblock CI.💡 Suggested formatting patch
Also applies to: 48-48, 63-63
🧰 Tools
🪛 GitHub Actions: PR testing - if Node project
[error] 33-33: ESLint (prettier/prettier): Prettier formatting error. Replace the single-line JSX
className/src/title/altwith the suggested multi-line formatting.🤖 Prompt for AI Agents