Skip to content

Re-do of plot_quick#1106

Open
eteq wants to merge 5 commits into
astropy:mainfrom
eteq:basic_plot_2
Open

Re-do of plot_quick#1106
eteq wants to merge 5 commits into
astropy:mainfrom
eteq:basic_plot_2

Conversation

@eteq
Copy link
Copy Markdown
Member

@eteq eteq commented Nov 15, 2023

This PR is a re-do of #650 for the current state of affairs where ndcube's plot() method exists on Spectrum1D. After some testing, a group of us realized the ndcube plot doesn't really represent well what plotting should be doing for a Spectrum1D. So this PR moves plot_quick to override the .plot() of ndcube. A few others at the workshop will fill in a follow-on comment later with the experimentation that demonstrated to this group why this is a good idea.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 15, 2023

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.81%. Comparing base (ba0ab68) to head (4ef4dcb).
⚠️ Report is 229 commits behind head on main.

Files with missing lines Patch % Lines
specutils/spectra/spectrum1d.py 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
+ Coverage   70.74%   70.81%   +0.07%     
==========================================
  Files          64       64              
  Lines        4484     4509      +25     
==========================================
+ Hits         3172     3193      +21     
- Misses       1312     1316       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants