Skip to content

[ty] Extract SequentMap and PathAssignments into dedicated modules - #28080

Merged
dcreager merged 2 commits into
mainfrom
dcreager/move-it-all
Aug 26, 2026
Merged

[ty] Extract SequentMap and PathAssignments into dedicated modules#28080
dcreager merged 2 commits into
mainfrom
dcreager/move-it-all

Conversation

@dcreager

Copy link
Copy Markdown
Member

This file's getting big. This is a pure refactoring that splits things up a bit.

@dcreager
dcreager requested a review from a team as a code owner August 26, 2026 20:01
@dcreager dcreager added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Aug 26, 2026
@astral-sh-bot
astral-sh-bot Bot requested a review from ibraheemdev August 26, 2026 20:01
@astral-sh-bot

astral-sh-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 97.79%. The percentage of expected errors that received a diagnostic held steady at 94.33%. The number of fully passing files held steady at 112/136.

@astral-sh-bot

astral-sh-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

/// pruned from the search), and new constraints that we can assume to be true even if we haven't
/// seen them directly.
///
/// Sequent maps are primarily used when walking a BDD path with a [`PathAssignments`]. The

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we now need to qualify this link as super::paths::PathAssignments, or import the type.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo doc is the local test I always forget to run!

@dcreager
dcreager force-pushed the dcreager/move-it-all branch from e802a02 to fde4834 Compare August 26, 2026 20:31
@dcreager
dcreager merged commit 9775a67 into main Aug 26, 2026
68 checks passed
@dcreager
dcreager deleted the dcreager/move-it-all branch August 26, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants