[ty] Optimize materialized recursive protocol comparisons - #28079
Open
carljm wants to merge 2 commits into
Open
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 97.79%. The percentage of expected errors that received a diagnostic held steady at 94.33%. The number of fully passing files held steady at 112/136. |
Memory usage reportMemory usage unchanged ✅ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing explicit receiver types on overloaded recursive protocol methods can repeatedly expand materialized protocol specializations until ty overflows its stack. This extends the non-recursive-member shortcut to eligible materialized assignability comparisons, avoiding that expansion while preserving inference constraints.
For two specializations of the same protocol, the shortcut checks the non-recursive target requirements against the complete source interface. It skips recursive requirements only when those constraints mention every type variable in both specializations, including through aliases, and imply the nominal type-argument relation. Opposite top-to-bottom materializations and comparisons that cannot establish this proof retain the full structural path.
On main, the added benchmark overflows the stack. With this change it completes in about 10 ms in a profiling build.
Part of astral-sh/ty#4269.
Test plan
Anyin a recursive method becomes an incompatible return requirement.