[ty] Factor function-level work out of pytest fixture request lookup - #28073
Merged
Conversation
lerebear
force-pushed
the
lerebear/push-okknqpkrxrpv
branch
from
August 26, 2026 19:32
e2d2206 to
191b17f
Compare
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 97.79%. The percentage of expected errors that received a diagnostic held steady at 94.33%. The number of fully passing files held steady at 112/136. |
Memory usage reportMemory usage unchanged ✅ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In anticipation of "find references" for pytest fixtures, which enumerates possible fixture requests across every parameter of a function, this PR factors the shared, function-level work in
fixture_request_for_parameterintoFixtureRequestContext.This lets the follow-up construct one context per function and reuse it for each candidate parameter, rather than repeatedly calling:
fixture_declaration,is_collected_test, andis_unittest_test_caseto determine whether the function can request fixtures.infer_definition_typesto retrieve the function type.mock_patch_countto determine how many parameters are supplied byunittest.mock.patch.The existing
fixture_request_for_parameterentry point now constructs a context and delegates to it, preserving behavior for existing callers. This is a behavior-preserving refactor.Test Plan
This is a refactor that relies on existing test coverage (although I have backfilled a new test for some pre-existing behaviour).