Skip to content

Include external repos through FetchContent - #14

Merged
willjwon merged 1 commit into
developfrom
yamlbuild
Nov 12, 2025
Merged

willjwon merged 1 commit into
developfrom
yamlbuild

Conversation

@jinsun-yoo

@jinsun-yoo jinsun-yoo commented Oct 20, 2025 •

Copy link
Copy Markdown
Contributor
  • currently the develop branch is behind main, hence landing on main.

The FetchContent syntax of CMake allows us to 1) link external repos without adding them as git submodules 2) define and link external repos in multiple places in multiple places without fear of overlapping.

Feature 2 allows us to include yaml-cpp in CMakeList.txt of both astra-sim and astra-network-analytical without collision

@jinsun-yoo jinsun-yoo changed the title Build yaml-cpp only when not built elsewhere Include external repos through FetchContent Nov 11, 2025
willjwon
willjwon previously approved these changes Nov 12, 2025

@willjwon willjwon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@willjwon
willjwon changed the base branch from main to develop November 12, 2025 02:47
@willjwon
willjwon dismissed their stale review November 12, 2025 02:47

The base branch was changed.

@willjwon

Copy link
Copy Markdown
Collaborator

Updated the base branch to develop instead of main

@willjwon
willjwon merged commit e8c5119 into develop Nov 12, 2025
9 checks passed
@willjwon
willjwon deleted the yamlbuild branch November 12, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants