feat: allow patching pnpm repo by nickschaap · Pull Request #2841 · aspect-build/rules_js

nickschaap · 2026-05-12T20:54:57Z

This change provides an API for end users to patch the PNPM repository

Changes are visible to end-users: yes/no

Searched for relevant documentation and updated as needed: yes/no
Breaking change (forces users to change their own code or config): yes/no
Suggested release notes appear below: yes/no

Test plan

Covered by existing test cases
New test cases added
Manual testing; please provide instructions so we can reproduce:

CLAassistant · 2026-05-12T20:55:03Z

All committers have signed the CLA.

aspect-workflows · 2026-05-12T20:55:05Z

Bazel 7 (Test)

257 test targets passed

Targets

//:node_modules_build_test [k8-fastbuild]                                                              47ms
//:npm_link_targets_node_modules_build_test [k8-fastbuild]                                             54ms
//:npm_link_targets_test [k8-fastbuild]                                                                127ms
//js/private/coverage:coverage_checked_test [k8-fastbuild]                                             66ms
//js/private/node-patches:checked_in_compile_test [k8-fastbuild]                                       63ms
//js/private/test/coverage:fail [k8-fastbuild]                                                         104ms
//js/private/test/data:chdir-source-data-relative [k8-fastbuild]                                       84ms
//js/private/test/data:extract-js_library-srcs-data [k8-fastbuild]                                     54ms
//js/private/test/data:extract-js_run_binary-srcs [k8-fastbuild]                                       40ms
//js/private/test/data:from-js_run_binary-js_library-data [k8-fastbuild]                               72ms
//js/private/test/data:from-js_run_binary-srcs [k8-fastbuild]                                          100ms
//js/private/test/data:from-parent-genrule [k8-fastbuild]                                              134ms
//js/private/test/data:from-parent-js_library-data [k8-fastbuild]                                      83ms
//js/private/test/data:source-data-rootpath [k8-fastbuild]                                             75ms
//js/private/test/fixed_args:fixed_args_test [k8-fastbuild]                                            110ms
//js/private/test/image/non_ascii:assert_custom_layer_groups_test_node_modules_test [k8-fastbuild]     44ms
//js/private/test/image/non_ascii:assert_custom_layer_groups_test_package_store_1p_test [k8-fastbuild] 46ms
//js/private/test/image:assert_custom_layers_nomatch_test_app_test [k8-fastbuild]                      45ms
//js/private/test/image:assert_custom_layers_nomatch_test_node_modules_test [k8-fastbuild]             45ms
//js/private/test/image:assert_custom_layers_nomatch_test_node_test [k8-fastbuild]                     51ms
//js/private/test/image:assert_custom_owner_test_package_store_1p_test [k8-fastbuild]                  45ms
//js/private/test/image:assert_default_test_app_test [k8-fastbuild]                                    57ms
//js/private/test/image:assert_default_test_node_modules_test [k8-fastbuild]                           48ms
//js/private/test/image:assert_default_test_node_test [k8-fastbuild]                                   55ms
//js/private/test/image:assert_regex_edge_cases_test_app_test [k8-fastbuild]                           51ms
//js/private/test/image:assert_regex_edge_cases_test_node_test [k8-fastbuild]                          61ms
//js/private/test/js_binary_sh:BAZEL_BINDIR_change_directory_test [k8-fastbuild]                       98ms
//js/private/test/js_binary_sh:BAZEL_BINDIR_test [k8-fastbuild]                                        88ms
//js/private/test/js_binary_sh:BAZEL_BUILD_FILE_PATH_test [k8-fastbuild]                               84ms
//js/private/test/js_binary_sh:BAZEL_PACKAGE_test [k8-fastbuild]                                       71ms
//js/private/test/js_binary_sh:BAZEL_TARGET_test [k8-fastbuild]                                        86ms
//js/private/test/js_binary_sh:JS_BINARY__BUILD_FILE_PATH_test [k8-fastbuild]                          80ms
//js/private/test/js_binary_sh:JS_BINARY__WORKSPACE_test [k8-fastbuild]                                80ms
//js/private/test/js_binary_sh:env_json_encode_launcher_escaped [k8-fastbuild]                         102ms
//js/private/test/js_binary_sh:env_json_launcher_escaped [k8-fastbuild]                                82ms
//js/private/test/js_binary_sh:env_json_obj_launcher_escaped [k8-fastbuild]                            113ms
//js/private/test/js_binary_sh:env_json_str_launcher_escaped [k8-fastbuild]                            91ms
//js/private/test/js_binary_sh:regexy-args [k8-fastbuild]                                              65ms
//js/private/test/js_binary_sh:regexy-args-1 [k8-fastbuild]                                            125ms
//js/private/test/js_run_devserver:node_modules_symlink_to_execroot_test [k8-fastbuild]                330ms
//js/private/test/node-patches:escape_node24_test [k8-fastbuild]                                       102ms
//js/private/test/node-patches:lstat_node20_test [k8-fastbuild]                                        161ms
//js/private/test/node-patches:lstat_node22_test [k8-fastbuild]                                        188ms
//js/private/test/node-patches:lstat_nodejs_test [k8-fastbuild]                                        262ms
//js/private/test/node-patches:opendir_node22_test [k8-fastbuild]                                      189ms
//js/private/test/node-patches:opendir_nodejs_test [k8-fastbuild]                                      185ms
//js/private/test/node-patches:readdir_node20_test [k8-fastbuild]                                      237ms
//js/private/test/node-patches:readdir_node24_cjs_test [k8-fastbuild]                                  194ms
//js/private/test/node-patches:readlink_node20_cjs_test [k8-fastbuild]                                 168ms
//js/private/test/node-patches:readlink_node22_cjs_test [k8-fastbuild]                                 172ms
//js/private/test/node-patches:readlink_node24_test [k8-fastbuild]                                     188ms
//js/private/test/node-patches:realpath_node20_test [k8-fastbuild]                                     253ms
//js/private/test/node-patches:realpath_nodejs_cjs_test [k8-fastbuild]                                 294ms
//js/private/test/proto:proto_rewrite_imports_test [k8-fastbuild]                                      47ms
//js/private/test:run_environment_info_tests_binary_env_test [k8-fastbuild]                            85ms
//js/private/test:run_environment_info_tests_binary_no_env_test [k8-fastbuild]                         36ms
//js/private/test:run_environment_info_tests_test_both_test [k8-fastbuild]                             37ms
//js/private/test:srcs_not_in_runfiles_test [k8-fastbuild]                                             64ms
//js/private/test:transitive_type_deps_test [k8-fastbuild]                                             59ms
//js/private/watch:watch_checked_0_test [k8-fastbuild]                                                 47ms
//js/private/watch:watch_checked_1_test [k8-fastbuild]                                                 31ms
//js/private/worker:worker_checked_test [k8-fastbuild]                                                 51ms
//npm/private/lifecycle/min:write_min_test [k8-fastbuild]                                              37ms
//npm/private/test/npm_package:test_pkg [k8-fastbuild]                                                 73ms
//npm/private/test/npm_package:test_pkg_2 [k8-fastbuild]                                               50ms
//npm/private/test/npm_package:test_pkg_4 [k8-fastbuild]                                               38ms
//npm/private/test/npm_package:test_pkg_5 [k8-fastbuild]                                               49ms
//npm/private/test/subs:subs_test [k8-fastbuild]                                                       66ms
//npm/private/test:__rollup-test [k8-fastbuild]                                                        180ms
//npm/private/test:npm_auth_tests_test_2 [k8-fastbuild]                                                53ms
//npm/private/test:pkg_versions_test [k8-fastbuild]                                                    55ms
//npm/private/test:test_generated_pkg_json___rollup-target__entry_point_tagged_manual [k8-fastbuild]   49ms
//npm/private/test:test_generated_pkg_json___rollup-target_js_info_files_tagged_manual [k8-fastbuild]  41ms
//npm/private/test:test_generated_pkg_json___rollup-target_runfiles_lib_tagged_manual [k8-fastbuild]   29ms
//npm/private/test:test_generated_pkg_json___rollup-target_runfiles_tagged_manual [k8-fastbuild]       41ms
//npm/private/test:test_npm_package_visibility_test_0 [k8-fastbuild]                                   36ms
//npm/private/test:test_npm_package_visibility_test_10 [k8-fastbuild]                                  43ms
//npm/private/test:test_npm_package_visibility_test_11 [k8-fastbuild]                                  58ms
//npm/private/test:test_npm_package_visibility_test_14 [k8-fastbuild]                                  50ms
//npm/private/test:test_npm_package_visibility_test_4 [k8-fastbuild]                                   40ms
//npm/private/test:test_npm_package_visibility_test_7 [k8-fastbuild]                                   47ms
//npm/private/test:test_npm_package_visibility_test_8 [k8-fastbuild]                                   51ms
//npm/private/test:test_npmrc_test_0 [k8-fastbuild]                                                    43ms
//npm/private/test:test_parse_pnpm_lock_test_1 [k8-fastbuild]                                          37ms
//npm/private/test:test_parse_pnpm_lock_test_2 [k8-fastbuild]                                          46ms
//npm/private/test:test_pnpm_test_0 [k8-fastbuild]                                                     39ms
//npm/private/test:test_pnpm_test_10 [k8-fastbuild]                                                    26ms
//npm/private/test:test_pnpm_test_3 [k8-fastbuild]                                                     75ms
//npm/private/test:test_pnpm_test_4 [k8-fastbuild]                                                     54ms
//npm/private/test:test_pnpm_test_7 [k8-fastbuild]                                                     100ms
//npm/private/test:test_pnpm_test_9 [k8-fastbuild]                                                     31ms
//npm/private/test:test_translate_lock_test_2 [k8-fastbuild]                                           26ms
//npm/private/test:test_utils_test_2 [k8-fastbuild]                                                    30ms
//npm/private/test:test_utils_test_5 [k8-fastbuild]                                                    26ms
//npm/private/test:write_npm_translate_lock_0_test [k8-fastbuild]                                      157ms
//npm/private/test:write_npm_translate_lock_4_test [k8-fastbuild]                                      103ms
//npm/private/test:write_npm_translate_lock_6_test [k8-fastbuild]                                      100ms
//npm/private/test:write_npm_translate_lock_7_test [k8-fastbuild]                                      141ms
//npm/private/test:write_npm_translate_lock_9_test [k8-fastbuild]                                      160ms
//tools:preset.update_test [k8-fastbuild]                                                              114ms
+ 157 other targets

Bazel 8 (Test)

1 test target passed

Targets

//npm/private/test:test_pnpm_test_12 [k8-fastbuild] 81ms

Total test execution time was 81ms. 216 tests (99.5%) were fully cached saving 27s.

Bazel 9 (Test)

1 test target passed

Targets

//npm/private/test:test_pnpm_test_12 [k8-fastbuild] 41ms

Total test execution time was 41ms. 216 tests (99.5%) were fully cached saving 30s.

Bazel 7 (Test)

e2e/bzlmod

7 test targets passed

Targets

//:check_styles [k8-fastbuild]                                                                         76ms
//:jasmine_test [k8-fastbuild]                                                                         128ms
//:node_modules_test [k8-fastbuild]                                                                    30ms
//:other_module_binary_test [k8-fastbuild]                                                             84ms
//:other_module_linked_packages [k8-fastbuild]                                                         22ms
//:other_module_run_binary_test [k8-fastbuild]                                                         45ms
//:test [k8-fastbuild]                                                                                 69ms

Bazel 8 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 642ms.

Bazel 9 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 596ms.

Bazel 7 (Test)

e2e/git_dep_metadata

1 test target passed

Targets

//:no_git_metadata_test                                                                                19ms

Bazel 8 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Bazel 9 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Bazel 7 (Test)

e2e/gyp_no_install_script

2 test targets passed

Targets

//:test [k8-fastbuild]                                                                                 46ms
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                                 66ms

Bazel 8 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

Bazel 9 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 46ms.

Bazel 7 (Test)

e2e/js_binary_workspace

4 test targets passed

Targets

//:js_run_binary_chdir_test [k8-fastbuild]                                                             51ms
//:test [k8-fastbuild]                                                                                 39ms
@@workspace~//:js_binary_chdir_test [k8-fastbuild]                                                     52ms
@@workspace~//:js_test_chdir_test [k8-fastbuild]                                                       85ms

Bazel 8 (Test)

e2e/js_binary_workspace

All tests were cache hits

4 tests (100.0%) were fully cached saving 226ms.

Bazel 9 (Test)

e2e/js_binary_workspace

All tests were cache hits

4 tests (100.0%) were fully cached saving 238ms.

Bazel 8 (Test)

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 4s.

Bazel 9 (Test)

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 4s.

Bazel 7 (Test)

e2e/nextjs

3 test targets passed

Targets

//v15/cjs:test [k8-fastbuild]                                                                          41ms
//v15/esm:test [k8-fastbuild]                                                                          29ms
//v15/mjs:test [k8-fastbuild]                                                                          92ms

Bazel 8 (Test)

e2e/nextjs

All tests were cache hits

3 tests (100.0%) were fully cached saving 94ms.

Bazel 9 (Test)

e2e/nextjs

All tests were cache hits

3 tests (100.0%) were fully cached saving 112ms.

Bazel 7 (Test)

e2e/npm_link_package

4 test targets passed

Targets

//cjs/src:test [k8-fastbuild]                                                                          156ms
//cjs:package_store_targets_test [k8-fastbuild]                                                        42ms
//esm/src:test [k8-fastbuild]                                                                          153ms
//esm:package_store_targets_test [k8-fastbuild]                                                        39ms

Bazel 8 (Test)

e2e/npm_link_package

All tests were cache hits

4 tests (100.0%) were fully cached saving 363ms.

Bazel 9 (Test)

e2e/npm_link_package

All tests were cache hits

4 tests (100.0%) were fully cached saving 415ms.

Bazel 7 (Test)

e2e/npm_link_package-rerooted

2 test targets passed

Targets

//root/src:test [k8-fastbuild]                                                                         131ms
//root:package_store_targets_test [k8-fastbuild]                                                       62ms

Bazel 8 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 139ms.

Bazel 9 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 186ms.

Bazel 7 (Test)

e2e/npm_translate_lock

3 test targets passed

Targets

//:test                                                                                                37ms
//:test_dev_filtering                                                                                  175ms
//:test_prod_filtering                                                                                 186ms

Bazel 8 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 287ms.

Bazel 9 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 289ms.

Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

3 test targets passed

Targets

//:test [k8-fastbuild]                                                                                 38ms
//:write_npm_translate_lock_defs_0_test [k8-fastbuild]                                                 72ms
//:write_npm_translate_lock_defs_1_test [k8-fastbuild]                                                 60ms

Bazel 8 (Test)

e2e/npm_translate_lock_disable_hooks

Waiting for runner...

Bazel 9 (Test)

e2e/npm_translate_lock_disable_hooks

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/npm_translate_lock_empty

2 test targets passed

Targets

//:test [k8-fastbuild]                                                                                 19ms
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                                 95ms

Bazel 8 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 114ms.

Bazel 9 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 105ms.

Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

1 test target passed

Targets

//:test_sh                                                                                             22ms

Bazel 8 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 21ms.

Bazel 9 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 86ms.

Bazel 7 (Test)

e2e/npm_translate_lock_multi

Waiting for runner...

Bazel 8 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 54ms.

Bazel 9 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 113ms.

Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

1 test target passed

Targets

//root:test                                                                                            34ms

Bazel 8 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Bazel 9 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 38ms.

Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

4 test targets passed

Targets

//:node_modules_test [k8-fastbuild]                                                                    26ms
//:test [k8-fastbuild]                                                                                 87ms
//:utils_test [k8-fastbuild]                                                                           78ms
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                                 81ms

Bazel 8 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 249ms.

Bazel 9 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 320ms.

Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

1 test target passed

Targets

//subdir:test                                                                                          50ms

Bazel 8 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 67ms.

Bazel 9 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

Bazel 7 (Test)

e2e/npm_translate_package_lock

Buildkite build #12694 is running...

Bazel 8 (Test)

e2e/npm_translate_package_lock

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/npm_translate_package_lock

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/npm_translate_yarn_lock

Buildkite build #12694 is running...

Bazel 8 (Test)

e2e/npm_translate_yarn_lock

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/npm_translate_yarn_lock

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/output_paths

Buildkite build #12694 is running...

Bazel 8 (Test)

e2e/output_paths

Waiting for runner...

Bazel 9 (Test)

e2e/output_paths

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/patch_from_repo

Waiting for runner...

Bazel 7 (Test)

e2e/pnpm_lockfiles

59 test targets passed

Targets

//cases/docusaurus-direct-peer-v9:docusaurus_direct_with_peers [k8-fastbuild]                          59ms
//cases/isaacs-cliui-v90:isaacs_cliui [k8-fastbuild]                                                   62ms
//cases/multi-document-v11:multi_document_v11 [k8-fastbuild]                                           47ms
//cases/nested-peer-v9:nested_peers_targets [k8-fastbuild]                                             43ms
//cases/override-with-alias-url-v9:override-with-alias-url-v9 [k8-fastbuild]                           33ms
//cases/versionless-patch-v9:versionless_patch_targets [k8-fastbuild]                                  49ms
//cases/versionless-patch-v9:versionless_patch_test [k8-fastbuild]                                     86ms
//cases/workspace-peer-v9:optional_peers_targets [k8-fastbuild]                                        37ms
//v101:aliases-test [k8-fastbuild]                                                                     227ms
//v101:patch-test [k8-fastbuild]                                                                       78ms
//v101:repos_0_test [k8-fastbuild]                                                                     75ms
//v101:repos_10_test [k8-fastbuild]                                                                    100ms
//v101:repos_11_test [k8-fastbuild]                                                                    106ms
//v101:repos_12_test [k8-fastbuild]                                                                    94ms
//v101:repos_13_test [k8-fastbuild]                                                                    123ms
//v101:repos_1_test [k8-fastbuild]                                                                     101ms
//v101:repos_2_test [k8-fastbuild]                                                                     75ms
//v101:repos_3_test [k8-fastbuild]                                                                     97ms
//v101:repos_4_test [k8-fastbuild]                                                                     80ms
//v101:repos_5_test [k8-fastbuild]                                                                     98ms
//v101:repos_6_test [k8-fastbuild]                                                                     93ms
//v101:repos_7_test [k8-fastbuild]                                                                     126ms
//v101:repos_8_test [k8-fastbuild]                                                                     76ms
//v101:repos_9_test [k8-fastbuild]                                                                     52ms
//v101:targets [k8-fastbuild]                                                                          27ms
//v110:aliases-test [k8-fastbuild]                                                                     154ms
//v110:patch-test [k8-fastbuild]                                                                       71ms
//v110:repos_0_test [k8-fastbuild]                                                                     132ms
//v110:repos_10_test [k8-fastbuild]                                                                    105ms
//v110:repos_11_test [k8-fastbuild]                                                                    96ms
//v110:repos_12_test [k8-fastbuild]                                                                    105ms
//v110:repos_13_test [k8-fastbuild]                                                                    136ms
//v110:repos_1_test [k8-fastbuild]                                                                     97ms
//v110:repos_2_test [k8-fastbuild]                                                                     113ms
//v110:repos_3_test [k8-fastbuild]                                                                     91ms
//v110:repos_4_test [k8-fastbuild]                                                                     99ms
//v110:repos_5_test [k8-fastbuild]                                                                     52ms
//v110:repos_6_test [k8-fastbuild]                                                                     97ms
//v110:repos_7_test [k8-fastbuild]                                                                     134ms
//v110:repos_8_test [k8-fastbuild]                                                                     93ms
//v110:repos_9_test [k8-fastbuild]                                                                     111ms
//v110:targets [k8-fastbuild]                                                                          27ms
//v90:aliases-test [k8-fastbuild]                                                                      143ms
//v90:patch-test [k8-fastbuild]                                                                        85ms
//v90:repos_0_test [k8-fastbuild]                                                                      101ms
//v90:repos_10_test [k8-fastbuild]                                                                     107ms
//v90:repos_11_test [k8-fastbuild]                                                                     110ms
//v90:repos_12_test [k8-fastbuild]                                                                     80ms
//v90:repos_13_test [k8-fastbuild]                                                                     120ms
//v90:repos_1_test [k8-fastbuild]                                                                      101ms
//v90:repos_2_test [k8-fastbuild]                                                                      106ms
//v90:repos_3_test [k8-fastbuild]                                                                      124ms
//v90:repos_4_test [k8-fastbuild]                                                                      98ms
//v90:repos_5_test [k8-fastbuild]                                                                      85ms
//v90:repos_6_test [k8-fastbuild]                                                                      97ms
//v90:repos_7_test [k8-fastbuild]                                                                      109ms
//v90:repos_8_test [k8-fastbuild]                                                                      115ms
//v90:repos_9_test [k8-fastbuild]                                                                      126ms
//v90:targets [k8-fastbuild]                                                                           32ms

Bazel 8 (Test)

e2e/pnpm_lockfiles

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/pnpm_lockfiles

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/pnpm_repo_install

Buildkite build #12694 is running...

Bazel 8 (Test)

e2e/pnpm_repo_install

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/pnpm_repo_install

All tests were cache hits

4 tests (100.0%) were fully cached saving 4s.

Bazel 7 (Test)

e2e/pnpm_workspace

15 test targets passed

Targets

//:node_test [k8-fastbuild]                                                                            271ms
//:repos_test [k8-fastbuild]                                                                           145ms
//:vendored [k8-fastbuild]                                                                             57ms
//app/a:aspect_test_a_bin_test [k8-fastbuild]                                                          108ms
//app/a:npm_link_targets_node_modules_build_test [k8-fastbuild]                                        77ms
//app/a:npm_link_targets_test [k8-fastbuild]                                                           133ms
//app/a:test [k8-fastbuild]                                                                            186ms
//app/b:aliases [k8-fastbuild]                                                                         73ms
//app/b:test [k8-fastbuild]                                                                            143ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]                                                          116ms
//app/c:test [k8-fastbuild]                                                                            147ms
//app/d:test [k8-fastbuild]                                                                            150ms
//lib/a:vendored [k8-fastbuild]                                                                        58ms
//lib/b:aliases [k8-fastbuild]                                                                         65ms
//lib/d:aliases [k8-fastbuild]                                                                         51ms

Bazel 8 (Test)

e2e/pnpm_workspace

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/pnpm_workspace

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/pnpm_workspace_deps

Buildkite build #12694 is running...

Bazel 8 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 278ms.

Bazel 9 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 237ms.

Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

Buildkite build #12694 is running...

Bazel 8 (Test)

e2e/pnpm_workspace_rerooted

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/pnpm_workspace_rerooted

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/protobuf-es

3 test targets passed

Targets

//:test [k8-fastbuild]                                                                                 148ms
//:test_connect [k8-fastbuild]                                                                         234ms
//:test_connect_query [k8-fastbuild]                                                                   332ms

Bazel 8 (Test)

e2e/protobuf-es

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/protobuf-es

All tests were cache hits

3 tests (100.0%) were fully cached saving 752ms.

Bazel 7 (Test)

e2e/protobuf-google

2 test targets passed

Targets

//:test [k8-fastbuild]                                                                                 95ms
//:test_grpc [k8-fastbuild]                                                                            180ms

Bazel 8 (Test)

e2e/protobuf-google

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/protobuf-google

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/repo_mapping

Waiting for runner...

Bazel 8 (Test)

e2e/repo_mapping

Waiting for runner...

Bazel 9 (Test)

e2e/repo_mapping

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/vendored_node

Waiting for runner...

Bazel 8 (Test)

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 57ms.

Bazel 9 (Test)

e2e/vendored_node

Buildkite build #12694 is running...

Bazel 7 (Test)

e2e/vendored_tarfile

Buildkite build #12694 is running...

Bazel 8 (Test)

e2e/vendored_tarfile

Buildkite build #12694 is running...

Bazel 9 (Test)

e2e/vendored_tarfile

Waiting for runner...

Bazel 7 (Test)

e2e/verify_patches

Waiting for runner...

Bazel 8 (Test)

e2e/verify_patches

Waiting for runner...

Bazel 9 (Test)

e2e/verify_patches

Buildkite build #12694 is running...

Bazel 7 (Test)

examples

83 test targets passed

Targets

//:linked_packages_build_test [k8-fastbuild]                                                           32ms
//coverage:coverage [k8-fastbuild]                                                                     81ms
//genrule:test_acorn [k8-fastbuild]                                                                    50ms
//genrule:test_require_acorn [k8-fastbuild]                                                            35ms
//js_binary:aspect_bin_a_test [k8-fastbuild]                                                           88ms
//js_binary:case7_test [k8-fastbuild]                                                                  127ms
//js_binary:npm_version_test [k8-fastbuild]                                                            231ms
//js_binary:test13-1_cjs [k8-fastbuild]                                                                46ms
//js_binary:test13-1_mjs [k8-fastbuild]                                                                28ms
//js_binary:test13-2_cjs [k8-fastbuild]                                                                34ms
//js_binary:test13-2_mjs [k8-fastbuild]                                                                52ms
//js_binary:test4-b_cjs [k8-fastbuild]                                                                 32ms
//js_binary:test4-b_mjs [k8-fastbuild]                                                                 35ms
//js_binary:test4-cjs-a [k8-fastbuild]                                                                 33ms
//js_binary:test4-mjs-a [k8-fastbuild]                                                                 52ms
//js_binary:test5_cjs [k8-fastbuild]                                                                   74ms
//js_binary:test5_mjs [k8-fastbuild]                                                                   50ms
//js_binary:test6 [k8-fastbuild]                                                                       49ms
//js_binary:test6_alt [k8-fastbuild]                                                                   42ms
//js_binary:test8 [k8-fastbuild]                                                                       113ms
//js_binary:test_cjs [k8-fastbuild]                                                                    153ms
//js_binary:test_exitcode [k8-fastbuild]                                                               73ms
//js_binary:test_js_binary_under_custom_rule [k8-fastbuild]                                            57ms
//js_binary:test_js_binary_under_custom_rule_local [k8-fastbuild]                                      94ms
//js_binary:test_js_binary_under_genrule_cjs [k8-fastbuild]                                            55ms
//js_binary:test_js_binary_under_genrule_mjs [k8-fastbuild]                                            44ms
//js_binary:test_js_binary_under_js_run_binary_cjs [k8-fastbuild]                                      64ms
//js_binary:test_js_binary_under_js_run_binary_local_cjs [k8-fastbuild]                                50ms
//js_binary:test_js_binary_under_js_run_binary_local_mjs [k8-fastbuild]                                70ms
//js_binary:test_js_binary_under_js_run_binary_mjs [k8-fastbuild]                                      82ms
//js_binary:test_js_binary_under_js_run_binary_no_copy_data_to_bin [k8-fastbuild]                      42ms
//js_binary:test_mjs [k8-fastbuild]                                                                    133ms
//js_binary:test_stderr [k8-fastbuild]                                                                 49ms
//js_binary:test_stdout [k8-fastbuild]                                                                 59ms
//js_lib_pkg/b:test_each_target [k8-fastbuild]                                                         80ms
//js_lib_pkg/b:test_parent_target [k8-fastbuild]                                                       157ms
//js_library/two:two_test [k8-fastbuild]                                                               110ms
//linked_consumer:direct [k8-fastbuild]                                                                85ms
//linked_consumer:pkg [k8-fastbuild]                                                                   97ms
//linked_consumer:sources_test [k8-fastbuild]                                                          45ms
//linked_consumer:types_test [k8-fastbuild]                                                            45ms
//linked_empty_node_modules:test [k8-fastbuild]                                                        47ms
//macro:test_all [k8-fastbuild]                                                                        543ms
//macro:test_cjs [k8-fastbuild]                                                                        469ms
//macro:test_esm [k8-fastbuild]                                                                        688ms
//macro:test_js [k8-fastbuild]                                                                         518ms
//nextjs:next_build_test [k8-fastbuild]                                                                36ms
//nextjs:write_next_links_defs_test [k8-fastbuild]                                                     83ms
//npm_deps/patches:patches_update_test [k8-fastbuild]                                                  79ms
//npm_deps:circular_deps_build_test [k8-fastbuild]                                                     50ms
//npm_deps:rollup_version_test [k8-fastbuild]                                                          166ms
//npm_deps:test1 [k8-fastbuild]                                                                        36ms
//npm_deps:test10_cjs [k8-fastbuild]                                                                   237ms
//npm_deps:test10_mjs [k8-fastbuild]                                                                   134ms
//npm_deps:test11_cjs [k8-fastbuild]                                                                   157ms
//npm_deps:test11_mjs [k8-fastbuild]                                                                   174ms
//npm_deps:test3 [k8-fastbuild]                                                                        84ms
//npm_deps:test4 [k8-fastbuild]                                                                        121ms
//npm_deps:test5 [k8-fastbuild]                                                                        63ms
//npm_deps:test5_alt [k8-fastbuild]                                                                    43ms
//npm_deps:test6 [k8-fastbuild]                                                                        147ms
//npm_deps:test7_a [k8-fastbuild]                                                                      123ms
//npm_deps:test7_b_cjs [k8-fastbuild]                                                                  183ms
//npm_deps:test7_b_mjs [k8-fastbuild]                                                                  208ms
//npm_deps:test8 [k8-fastbuild]                                                                        93ms
//npm_deps:test9_cjs [k8-fastbuild]                                                                    127ms
//npm_deps:test9_mjs [k8-fastbuild]                                                                    128ms
//npm_deps:test_peer [k8-fastbuild]                                                                    128ms
//npm_deps:test_uvu_version [k8-fastbuild]                                                             194ms
//package_json_module:test [k8-fastbuild]                                                              358ms
//runfiles:module_name_runfiles [k8-fastbuild]                                                         140ms
//runfiles:outer_runfiles [k8-fastbuild]                                                               221ms
//runfiles:run_outer_binary_asserts__direct_srcs [k8-fastbuild]                                        100ms
//runfiles:run_outer_binary_asserts__transitive_data [k8-fastbuild]                                    117ms
//runfiles:run_test_binary_asserts__direct_srcs [k8-fastbuild]                                         126ms
//runfiles:run_test_binary_asserts__transitive_data [k8-fastbuild]                                     129ms
//runfiles:runfiles [k8-fastbuild]                                                                     98ms
//stack_traces:stack_traces [k8-fastbuild]                                                             127ms
//stamped_package_json:stamp_test [k8-fastbuild]                                                       56ms
//vite3:build_test [k8-fastbuild]                                                                      26ms
//vite6:build_test [k8-fastbuild]                                                                      37ms
//webpack_cli:test [k8-fastbuild]                                                                      438ms
//worker:test_pi [k8-fastbuild]                                                                        74ms

Bazel 8 (Test)

examples

All tests were cache hits

81 tests (100.0%) were fully cached saving 11s.

Bazel 9 (Test)

examples

All tests were cache hits

81 tests (100.0%) were fully cached saving 12s.

Buildifier Format

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a656c7097f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector Bot reviewed May 12, 2026

View reviewed changes

Comment thread npm/private/pnpm_extension.bzl Outdated

feat: allow patching pnpm repo

88b824e

nickschaap force-pushed the schaap/pnpm-patch branch from a656c70 to 88b824e Compare May 12, 2026 21:22

nickschaap added 2 commits May 12, 2026 18:12

chore: format

c3feca7

Merge branch 'main' into schaap/pnpm-patch

7f7fa29

jbedard approved these changes May 13, 2026

View reviewed changes

jbedard merged commit eaf500a into aspect-build:main May 13, 2026
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: allow patching pnpm repo#2841

feat: allow patching pnpm repo#2841
jbedard merged 3 commits into
aspect-build:mainfrom
nickschaap:schaap/pnpm-patch

nickschaap commented May 12, 2026

Uh oh!

CLAassistant commented May 12, 2026 •

edited

Loading

Uh oh!

aspect-workflows Bot commented May 12, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nickschaap commented May 12, 2026

Changes are visible to end-users: yes/no

Test plan

Uh oh!

CLAassistant commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aspect-workflows Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

e2e/bzlmod

e2e/bzlmod

e2e/bzlmod

e2e/git_dep_metadata

e2e/git_dep_metadata

e2e/git_dep_metadata

e2e/gyp_no_install_script

e2e/gyp_no_install_script

e2e/gyp_no_install_script

e2e/js_binary_workspace

e2e/js_binary_workspace

e2e/js_binary_workspace

e2e/js_image_oci

e2e/js_image_oci

e2e/nextjs

e2e/nextjs

e2e/nextjs

e2e/npm_link_package

e2e/npm_link_package

e2e/npm_link_package

e2e/npm_link_package-rerooted

e2e/npm_link_package-rerooted

e2e/npm_link_package-rerooted

e2e/npm_translate_lock

e2e/npm_translate_lock

e2e/npm_translate_lock

e2e/npm_translate_lock_disable_hooks

Bazel 8 (Test)

e2e/npm_translate_lock_disable_hooks

e2e/npm_translate_lock_disable_hooks

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_exclude_package_contents

e2e/npm_translate_lock_exclude_package_contents

e2e/npm_translate_lock_exclude_package_contents

Bazel 7 (Test)

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_package_lock

e2e/npm_translate_package_lock

e2e/npm_translate_package_lock

e2e/npm_translate_yarn_lock

Bazel 8 (Test)

e2e/npm_translate_yarn_lock

e2e/npm_translate_yarn_lock

Bazel 7 (Test)

e2e/output_paths

Bazel 8 (Test)

e2e/output_paths

e2e/output_paths

Bazel 7 (Test)

e2e/patch_from_repo

e2e/pnpm_lockfiles

e2e/pnpm_lockfiles

Bazel 9 (Test)

e2e/pnpm_lockfiles

e2e/pnpm_repo_install

e2e/pnpm_repo_install

CLAassistant commented May 12, 2026 •

edited

Loading

aspect-workflows Bot commented May 12, 2026 •

edited

Loading