-
Notifications
You must be signed in to change notification settings - Fork 59
Refactor and Cleanup Webagent #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| from .android_base_tool import AndroidBaseTool | ||
| from .computer_base_tool import ComputerBaseTool | ||
| from .playwright_base_tool import PlaywrightBaseTool | ||
| from .tool_tags import ToolTags | ||
|
|
||
| __all__ = [ | ||
| "AndroidBaseTool", | ||
| "ComputerBaseTool", | ||
| "PlaywrightBaseTool", | ||
| "ToolTags", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,57 @@ | ||||||||||||||
| from typing import Any | ||||||||||||||
|
|
||||||||||||||
| from askui.models.shared.tool_tags import ToolTags | ||||||||||||||
| from askui.models.shared.tools import ToolWithAgentOS | ||||||||||||||
| from askui.tools.agent_os import AgentOs | ||||||||||||||
| from askui.tools.agent_os_type_error import AgentOsTypeError | ||||||||||||||
| from askui.tools.android.agent_os import AndroidAgentOs | ||||||||||||||
| from askui.tools.playwright.agent_os import PlaywrightAgentOs | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| class PlaywrightBaseTool(ToolWithAgentOS): | ||||||||||||||
| """Tool base class that has an the Playwright AgentOs available.""" | ||||||||||||||
|
|
||||||||||||||
| def __init__( | ||||||||||||||
| self, | ||||||||||||||
| agent_os: AgentOs | None = None, | ||||||||||||||
| required_tags: list[str] | None = None, | ||||||||||||||
| **kwargs: Any, | ||||||||||||||
| ) -> None: | ||||||||||||||
| super().__init__( | ||||||||||||||
| required_tags=[ToolTags.PLAYWRIGHT.value] + (required_tags or []), | ||||||||||||||
| agent_os=agent_os, | ||||||||||||||
| **kwargs, | ||||||||||||||
| ) | ||||||||||||||
|
|
||||||||||||||
| @property | ||||||||||||||
| def agent_os(self) -> PlaywrightAgentOs: | ||||||||||||||
| """Get the agent OS. | ||||||||||||||
|
|
||||||||||||||
| Returns: | ||||||||||||||
| PlaywrightAgentOs: The Playwright agent OS instance. | ||||||||||||||
| """ | ||||||||||||||
| agent_os = super().agent_os | ||||||||||||||
| if not isinstance(agent_os, PlaywrightAgentOs): | ||||||||||||||
| raise AgentOsTypeError( | ||||||||||||||
| expected_type=PlaywrightAgentOs, | ||||||||||||||
| actual_type=type(agent_os), | ||||||||||||||
| ) | ||||||||||||||
| return agent_os | ||||||||||||||
|
|
||||||||||||||
| @agent_os.setter | ||||||||||||||
| def agent_os(self, agent_os: AgentOs | AndroidAgentOs | PlaywrightAgentOs) -> None: | ||||||||||||||
| """Set the agent OS. | ||||||||||||||
|
|
||||||||||||||
| Args: | ||||||||||||||
| agent_os (AgentOs | AndroidAgentOs | PlaywrightAgentOs): The agent OS | ||||||||||||||
| instance to set. | ||||||||||||||
|
|
||||||||||||||
| Raises: | ||||||||||||||
| TypeError: If the agent OS is not an `AgentOs` instance. | ||||||||||||||
| """ | ||||||||||||||
| if not isinstance(agent_os, AgentOs): | ||||||||||||||
| raise AgentOsTypeError( | ||||||||||||||
| expected_type=AgentOs, | ||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
| actual_type=type(agent_os), | ||||||||||||||
| ) | ||||||||||||||
| self._agent_os = agent_os | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.