Skip to content

fix(analyze): flag task data-loading effects - #57

Closed
lntutor wants to merge 1 commit into
askrjs:mainfrom
lntutor:fix/49-no-effect-data-loading
Closed

fix(analyze): flag task data-loading effects#57
lntutor wants to merge 1 commit into
askrjs:mainfrom
lntutor:fix/49-no-effect-data-loading

Conversation

@lntutor

@lntutor lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add askr/no-effect-data-loading for async task() callbacks that fetch and write component-owned state
  • use existing state binding ownership to avoid unrelated/module-owned setters
  • keep analytics fetches and non-fetch state tasks valid

Closes #49.

Test plan

  • npm test -- tests/analyze.rules.test.ts
  • npm run check

@lntutor
lntutor requested a review from smiggleworth as a code owner July 30, 2026 16:06
@lntutor

lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #58, which landed the no-effect-data-loading rule and coverage on main. Closing this duplicate to keep the review queue clean.

@lntutor lntutor closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyze: report task() used as a data-loading effect instead of resource()

1 participant