Skip to content

fix(analyze): require flush before assertions - #56

Closed
lntutor wants to merge 1 commit into
askrjs:mainfrom
lntutor:fix/50-testing-flush-contract
Closed

fix(analyze): require flush before assertions#56
lntutor wants to merge 1 commit into
askrjs:mainfrom
lntutor:fix/50-testing-flush-contract

Conversation

@lntutor

@lntutor lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the first-stage askr/testing-contract check for stale post-dispatch assertions
  • require an awaited flush() before the next expect/assert in the same block
  • scope detection to canonical imports from @askrjs/askr/testing, including aliases

Closes #50.

Test plan

  • npm test -- tests/analyze.rules.test.ts
  • npm run check

@lntutor
lntutor requested a review from smiggleworth as a code owner July 30, 2026 16:03
@lntutor

lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #58, which landed the testing-contract flush rule and coverage on main. Closing this duplicate to keep the review queue clean.

@lntutor lntutor closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyze: report missing await flush() and cleanup() in @askrjs/askr/testing tests

1 participant