Skip to content

fix(analyze): require stable module identities - #54

Closed
lntutor wants to merge 1 commit into
askrjs:mainfrom
lntutor:fix/44-stable-module-identity
Closed

fix(analyze): require stable module identities#54
lntutor wants to merge 1 commit into
askrjs:mainfrom
lntutor:fix/44-stable-module-identity

Conversation

@lntutor

@lntutor lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add askr/stable-module-identity for lazy() and defineScope() calls inside functions
  • keep module-scope identities valid and document the new correctness rule
  • hoist startkit lazy route components so shipped templates remain analyzer-clean

Closes #44.

Test plan

  • npm test -- tests/analyze.rules.test.ts
  • npm test -- tests/guardrails.test.ts
  • npm run check

@lntutor
lntutor requested a review from smiggleworth as a code owner July 30, 2026 15:59
@lntutor

lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #58, which landed the stable-module-identity rule and its coverage on main. Closing this duplicate to keep the review queue clean.

@lntutor lntutor closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyze: lazy() and defineScope() must be declared at module scope

1 participant