Repository navigation
Fix bfmi with non-default chain_axis and draw_axis - #494
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 48 48
Lines 6978 6978
=======================================
Hits 5906 5906
Misses 1072 1072 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Documentation build overview
12 files changed ·
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bfmifails on arrays where the chain axis is not second to last. With draws-first energy,azs.bfmi(energy.T, chain_axis=1, draw_axis=0)raisesValueError: could not broadcast input array from shape (4,) into shape (100,)instead of returning the same values asazs.bfmi(energy). The output shape was read with the originalchain_axisafter the array had already been transposed to put chain and draw last, so it now usesary.shape[-2]. Added a test with chain/draw on axes (0, 1) and (2, 0) that checks the result against the BFMI formula.Written with help from Claude.