Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix inconsistent cookie deletion by enforcing Expires header alongside MaxAge#491

Draft
arumes31 wants to merge 1 commit into
mainfrom
jules-744770133883656375-8b3d5452
Draft

πŸ›‘οΈ Sentinel: [MEDIUM] Fix inconsistent cookie deletion by enforcing Expires header alongside MaxAge#491
arumes31 wants to merge 1 commit into
mainfrom
jules-744770133883656375-8b3d5452

Conversation

@arumes31

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Some browsers may not correctly clear session cookies if MaxAge: -1 is supplied without an Expires date in the past, or vice-versa.
🎯 Impact: Session cookies could potentially persist longer than intended, leaving a window open for unauthorized session reuse.
πŸ”§ Fix: Add Expires: time.Unix(0, 0) to the cookie deletion structures in internal/handlers/auth.go to explicitly enforce expiration in the past alongside MaxAge: -1.
βœ… Verification: Ran go test ./... to ensure no functionality is broken and formatting passes.


PR created automatically by Jules for task 744770133883656375 started by @arumes31

Added the `Expires: time.Unix(0, 0)` property to `rauth_2fa_pending` and
`rauth_setup_pending` cookies during deletion to ensure compatibility with
browsers that may not fully honor `MaxAge: -1` on its own.

Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4fec4d1e-53fd-4b5d-9d64-8abd4b93334c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • πŸ” Trigger review
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jules-744770133883656375-8b3d5452

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant