π‘οΈ Sentinel: [MEDIUM] Fix inconsistent cookie deletion by enforcing Expires header alongside MaxAge#491
π‘οΈ Sentinel: [MEDIUM] Fix inconsistent cookie deletion by enforcing Expires header alongside MaxAge#491arumes31 wants to merge 1 commit into
Conversation
Added the `Expires: time.Unix(0, 0)` property to `rauth_2fa_pending` and `rauth_setup_pending` cookies during deletion to ensure compatibility with browsers that may not fully honor `MaxAge: -1` on its own. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¨ Severity: MEDIUM
π‘ Vulnerability: Some browsers may not correctly clear session cookies if
MaxAge: -1is supplied without anExpiresdate in the past, or vice-versa.π― Impact: Session cookies could potentially persist longer than intended, leaving a window open for unauthorized session reuse.
π§ Fix: Add
Expires: time.Unix(0, 0)to the cookie deletion structures ininternal/handlers/auth.goto explicitly enforce expiration in the past alongsideMaxAge: -1.β Verification: Ran
go test ./...to ensure no functionality is broken and formatting passes.PR created automatically by Jules for task 744770133883656375 started by @arumes31