Skip to content

Add margin-top to p elements in accordion [PUB-306]#724

Merged
trevinalonzo merged 3 commits into
developfrom
fix/ranged-accordion-headers
Mar 27, 2025
Merged

Add margin-top to p elements in accordion [PUB-306]#724
trevinalonzo merged 3 commits into
developfrom
fix/ranged-accordion-headers

Conversation

@trevinalonzo

Copy link
Copy Markdown
Member

No description provided.

@trevinalonzo trevinalonzo self-assigned this Mar 27, 2025
'value' => '/collection/articlesPublications/digitalPublicationsBrowser/articles/browser?digitalPublication=' . $item->id
]
]"
:params="[ 'digitalPublication' => $item->id, ]"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a PR to Twill to actually implement the :params option:
area17/twill#2752

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... well this works and i needed to update the url path anyway 🤷

@zachgarwood zachgarwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trevinalonzo trevinalonzo force-pushed the fix/ranged-accordion-headers branch from 5021026 to c81b4b9 Compare March 27, 2025 22:15
@trevinalonzo trevinalonzo merged commit 4ed9399 into develop Mar 27, 2025
@trevinalonzo trevinalonzo deleted the fix/ranged-accordion-headers branch March 27, 2025 22:15
@sonarqubecloud

Copy link
Copy Markdown

nikhiltri pushed a commit that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants