Repository navigation
Conversation
glubsy
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI stops at the first file error, leaving later files unprocessed. Add
--continue-on-errorto attempt the rest of the batch while reporting each error on stderr and exiting with status 1 if any operation failed. The default behavior and Python API stay unchanged.Related to #99: this covers command-line use only, not the requested Python API option.
Validation on Windows with Python 3.14.7:
python -m flake8 send2trash testsandgit diff --checkpassed.python -m send2trashsubprocess run with a missing file followed by an existing test file confirmed that the default preserves the later file, the new option sends it to the Recycle Bin, and both invocations return status 1.Linux and macOS have not been tested locally.