Repository navigation
Conversation
glubsy
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98.
When the home directory is a symlink located on a different filesystem from its target, the Freedesktop backend uses
lstaton the link to choose the trash device. A file inside the actual home is then treated as external, potentially failing to find a writable volume trash even though its home trash is available.Resolve the home path before probing its device. The source path still uses
lstat, so trashing a symlink moves the link itself. Regression cases cover ordinary files and symlink sources, including the initially absent home trash.Validation on Linux/arm64, Python 3.14.4:
/tmppointing into/dev/shm(different device IDs) and verified the file and its trashinfo reached the home trash.git diff --checkpass.macOS and Windows were not run locally. Developed and verified with AI assistance.