Repository navigation
Conversation
Author
|
This was closed accidentally by our downstream workaround PR closing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This issue is affecting PrairieLearn downstream! We'd appreciate a swift resolution so we can revert our workaround.
This fix:
theme="light"overrideprefers-color-scheme: darkfor mathfield, shared UI, and menu colorstheme="dark"behavior on light systemsFixes #2999.
Supersedes #3000.
Prior art
theme="light"overprefers-color-scheme: dark#3000 established the:not([theme="light"])direction and the initial theme test matrixpl-symbolic-inputSelection BG Color Goes Black PrairieLearn/PrairieLearn#14766 documents the downstream user-visible failureThis replacement is based on current
master, omits the unrelated virtual-keyboard cleanup from #3000, and uses:where()to avoid raising selector specificity above the later forced-colors rules.Testing
mouse.spec.ts, expectedx+y=30, received an empty value) that reproduces in isolation and is unrelated to these CSS changes.npm run lintreports the existingno-restricted-globalserror forspeechSynthesisinsrc/public/math-static-elements.ts; changed files are formatted.