fix: Enable user selection for math static elements - #3061
Open
tsuji-riya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to enable user selection on
<math-span />and<math-div />elements.To do this, I removed
user-select: nonefrom the.ML__latexCSS class in core.less, so users can now select and copy the math content.But this had a side effect: the
_mathMLContainer(a hidden MathML element used for screen readers/accessibility) also became selectable, causing the same math expression to be duplicated when copied. To fix this, I addeduser-select: nonedirectly on_mathMLContainerin math-static-elements.ts, so only that element is excluded from selection/copy while the visible math stays selectable.