remove trailing slash for overrideUrlName

[jordiprats]

Hi,
This PR is for fixing what could be also considered as a configuration mistake. If you set overrideBaseUrl to an url with a trailing slash as follows:

        apiSecurity:
          overrideBaseUrl: http://whatever.com/
        uiSecurity:
          overrideBaseUrl: http://whatever.com/

It looks like everything is fine but if you click on the source link on any pipeline you'll get this error message:

The request was rejected because the URL contained a potentially malicious String

Taking a look at the URL you'll realize there's a double slash after the hostname which leads to this error. On my PR you'll find the code needed for ignoring this final slash: It doesn't even matter if you remove it or add the final slash: the operator won't even bother updating the containers because it's just ignored

kind regards,

[jordiprats]

Regading the failed build looks like it's something unrelated to the code:

Run docker login -u  -p "" registry.redhat.io
"docker login" requires at most 1 argument.
See 'docker login --help'.

Usage:  docker login [OPTIONS] [SERVER]

Log in to a Docker registry
Error: Process completed with exit code 1.

[dmyerscough]

You should leverage strings and do strings.HasPrefix(overrideUrlName, "/")

if strings.HasPrefix(overrideUrlName, "/") {
    overrideUrlName = overrideUrlName[:len(overrideUrlName) - 1]
}

You could drop the else and the additional variable.

[jordiprats]

Good point, although it is actually HasSuffix: tests whether the string s ends with suffix.

I have pushed an amended commit for this

[jordiprats]

This change is quite straightforward and it's going to help users avoid getting stuck with this issue. Can someone take a look?

[ichi0915]

Thank you for this, I don't have permissions to merge this until the actions have passed let me see who can help us get this merge

[ichi0915]

@jordiprats can you help us rebasing to the latest commits in master or maybe create an empty commit just to re-run the actions and see the output.

[jordiprats]

@ichi0915 sorry I messed up with this PR, I have created a new one with the change rebased: #267