feat!: show actionable connectivity health fixes#277
Closed
federicobozzini wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
federicobozzini
commented
May 29, 2026
| return res | ||
| } | ||
|
|
||
| func healthCheckWithStatusFromError(check HealthCheck, err error, fix *Fix) HealthCheck { |
Contributor
Author
There was a problem hiding this comment.
I'm not crazy about this name but it's the best I could come up with 🤷
muchzill4
reviewed
Jun 1, 2026
Contributor
muchzill4
left a comment
muchzill4
left a comment
There was a problem hiding this comment.
What makes this a breaking change?
| assert.JSONEq(t, `[]`, string(result["dependencies"])) | ||
| }) | ||
|
|
||
| t.Run("includes connectivity fix", func(t *testing.T) { |
Contributor
There was a problem hiding this comment.
- What additional coverage does this test add over what we have already?
- If there's something we want to test, testing it via json representation of the structs is an odd. Are we trying to cover how the data is converted to json here? Am I missing something?
Contributor
|
This does not add any new functionality nor is a breaking change. 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
For example: