Skip to content

Re-enable coveralls code coverage by adding coveralls action to github actions workflow#581

Open
jwlodek wants to merge 11 commits intoareaDetector:masterfrom
jwlodek:fix-coveralls
Open

Re-enable coveralls code coverage by adding coveralls action to github actions workflow#581
jwlodek wants to merge 11 commits intoareaDetector:masterfrom
jwlodek:fix-coveralls

Conversation

@jwlodek
Copy link
Copy Markdown
Member

@jwlodek jwlodek commented Apr 27, 2026

  • Remove unused travis ci configuration file
  • Update github actions CI configuration to re-enable coveralls code coverage metrics

@jwlodek
Copy link
Copy Markdown
Member Author

jwlodek commented Apr 27, 2026

This appears to have worked:

image

@jwlodek jwlodek changed the title "Re-enable coveralls code coverage by adding coveralls action to github actions workflow" Re-enable coveralls code coverage by adding coveralls action to github actions workflow Apr 27, 2026
@jwlodek
Copy link
Copy Markdown
Member Author

jwlodek commented Apr 27, 2026

I've moved the coverage check to the matrix job that builds against adsupport, to guarantee that most dependency libraries are available - I noticed that on the default ubuntu-latest/os/default the lz4 and bslz4 tests in the Codec tests did not get covered, presumably since there isn't a bitshuffle OS package.

@jwlodek
Copy link
Copy Markdown
Member Author

jwlodek commented Apr 27, 2026

Hmm, now it picked up those branches in the Codec tests, but I don't seem to get .gcda files for all of the files I'd expect (e.g. ADDriver.cpp is not listed). The previous run listed 59 files, the new one only 37. Need to investigate further.

@jwlodek
Copy link
Copy Markdown
Member Author

jwlodek commented Apr 28, 2026

Ok, figured out that this was caused by difference in gcda file generation between static/shared builds. I added a linux/adsupport/shared entry to the matrix, and have used that for the coverage. This should now be good to go.

@jwlodek jwlodek requested a review from MarkRivers April 28, 2026 16:46
Copy link
Copy Markdown
Member

@MarkRivers MarkRivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I am not an expert in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants