Skip to content

fix: Issue#123 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naveensrinivas282 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Issue#123 #141

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1534d7
fix: Issue#123
naveensrinivas282 Jul 30, 2025
d892214
fix: added timestamps to the tarball
naveensrinivas282 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@ tag:
.PHONY: release
release:
mkdir -p releases
git -c tar.tar.gz.command='gzip -cn' archive --prefix=${PROGNM}-${TAG}/ -o releases/${PROGNM}-${TAG}.tar.gz ${TAG}
git archive --format=tar.gz --prefix=${PROGNM}-${TAG}/ -o releases/${PROGNM}-${TAG}.tar.gz ${TAG}
Copy link
Copy Markdown
Member

@jelly jelly Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong, we want to keep comand='gzip -cn'. I don't really understand the original issue #123 but we drop timestamps for a reason.

Copy link
Copy Markdown
Author

@naveensrinivas282 naveensrinivas282 Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the required change to keep the timestamps and run gzip -cn. Please look through it

Copy link
Copy Markdown
Member

@kpcyrd kpcyrd Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #123 has already been fixed in de83e94

gpg --detach-sign -o releases/${PROGNM}-${TAG}.tar.gz.sig releases/${PROGNM}-${TAG}.tar.gz
gh release create -t "Release: ${TAG}" ${TAG} releases/${PROGNM}-${TAG}.tar.gz.sig releases/${PROGNM}-${TAG}.tar.gz