Port to Minecraft 26.1#708
Open
mrafto wants to merge 11 commits intoarchitectury:1.21.11from
Open
Conversation
|
|
### Ran `./gradlew :fabric:build :neoforge:build --no-daemon` `./gradlew :common:compileJava :fabric:compileJava :forge:compileJava :neoforge:compileJava --configure-on-demand --no-daemon` ### Changed - update build setup for Minecraft 26.1.1 / Java 25 / Architectury Loom 1.14 - include `fabric`, `forge`, and `neoforge` in the main Gradle build - port Forge/NeoForge event, registry, rendering, screen, particle, biome modification, item/fluid hook paths - update fluid stack serialization/component handling for Forge-like platforms - update NeoForge client fluid texture/tint lookup for the 26.1 baked fluid model path - preserve Architectury trade-registration callbacks by appending registered offers when villager / wandering-trader offers are rebuilt
Fabric trades no longer throw: TradeRegistryImpl.java:44 Added Fabric trade append mixins: MixinVillager.java:31 and MixinWanderingTrader.java:31 NeoForge EnteringSection now forwards to Architectury ENTER_SECTION: EventHandlerImplCommon.java:255 NeoForge spawn event now passes classic block-spawner / spawner-minecart BaseSpawner where available: EventHandlerImplCommon.java:265
Author
|
I set this to merge into 1.21.11, but the maintainer should create a new branch 26.1 for this PR. |
|
Is this on Maven? I wish to use it in assistance with my mod. |
|
You need to update the github workflows as well. To use java 25 since that's why it's failing right now. |
|
Does this work, or is this still a draft? |
2 tasks
|
Any progress here? |
|
bro please merge already 😭 |
|
|
😭😭 |
|
|
I've built this based on PR #708 mentioned here. If there are bugs, you can report them to the issues on my fork, and I'll try to fix them and submit a new PR to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports Architectury API to Minecraft 26.1 and 26.1.1.
Works quite well for both NeoForge and Fabric.
This has been tested with my RoughlyEnoughItems port for Minecraft 26.1.