Skip to content

ci: expand syntax check coverage for Python packages and GitHub scripts - #22

Open
Nitro-Builds-Yash wants to merge 1 commit into
arcahyadi:mainfrom
Nitro-Builds-Yash:fix/expand-ci-syntax-coverage
Open

Nitro-Builds-Yash wants to merge 1 commit into
arcahyadi:mainfrom
Nitro-Builds-Yash:fix/expand-ci-syntax-coverage

Conversation

@Nitro-Builds-Yash

Copy link
Copy Markdown

Summary

Expand syntax verification in .github/workflows/ci.yml so that:

  1. Python compileall check includes previously omitted root scripts (launcher.py, setup.py) and top-level packages (companion, config, integrations, mcp_servers).
  2. Node check includes .github/scripts/*.js in addition to static/app.js and static/js/**/*.js.

This ensures any syntax error in newly introduced scripts or packages is caught early in CI before merge.

Target branch

  • This PR targets dev, not main. (Note: targeting main as dev branch is not present on upstream)

Linked Issue

Fixes #19

Type of Change

  • Bug fix (non-breaking — fixes a confirmed issue)
  • New feature (non-breaking — adds new behaviour)
  • Breaking change (changes or removes existing behaviour)
  • Refactor / cleanup (behaviour unchanged)
  • Documentation only
  • CI / tooling / configuration

Checklist

  • I searched open issues and open PRs — this is not a duplicate.
  • This PR targets main
  • My changes are limited to the scope described above — no unrelated refactors or whitespace changes mixed in.
  • I actually ran the app (docker compose up or uvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.

How to Test

Run the exact compileall command locally: python -m compileall -q app.py launcher.py setup.py companion config core integrations mcp_servers routes scripts services src tests. Run the node check on scripts: node --check .github/scripts/check-issue-description.js .github/scripts/check-pr-description.js. Both commands exit with status 0.

rennf93 pushed a commit to rennf93/odysseus that referenced this pull request Oct 10, 2026
…ckage

refactor(routes): move the email modules into routes/email/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants