Repository navigation
ci: expand syntax check coverage for Python packages and GitHub scripts - #22
Open
Nitro-Builds-Yash wants to merge 1 commit into
Open
Nitro-Builds-Yash wants to merge 1 commit into
Nitro-Builds-Yash wants to merge 1 commit into
Conversation
rennf93
pushed a commit
to rennf93/odysseus
that referenced
this pull request
Oct 10, 2026
…ckage refactor(routes): move the email modules into routes/email/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand syntax verification in
.github/workflows/ci.ymlso that:launcher.py,setup.py) and top-level packages (companion,config,integrations,mcp_servers)..github/scripts/*.jsin addition tostatic/app.jsandstatic/js/**/*.js.This ensures any syntax error in newly introduced scripts or packages is caught early in CI before merge.
Target branch
dev, notmain. (Note: targetingmainasdevbranch is not present on upstream)Linked Issue
Fixes #19
Type of Change
Checklist
maindocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.How to Test
Run the exact compileall command locally:
python -m compileall -q app.py launcher.py setup.py companion config core integrations mcp_servers routes scripts services src tests. Run the node check on scripts:node --check .github/scripts/check-issue-description.js .github/scripts/check-pr-description.js. Both commands exit with status 0.