Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .agents/shared/metrics/hits.jsonl
Original file line number Diff line number Diff line change
Expand Up @@ -161,3 +161,21 @@
{"ts":"2026-08-04T12:34:05.191Z","tool":"Edit","file":"apps/app/src/modules/governance/api/executeSelectorsService/queries/useAllAllowedActions/useAllAllowedActions.ts","rule":"query-and-cache","bytes":2385,"elapsed_ms":1,"adapter":"claude"}
{"ts":"2026-08-04T12:34:06.974Z","tool":"Edit","file":"apps/app/src/modules/governance/api/executeSelectorsService/queries/useAllAllowedActions/useAllAllowedActions.ts","rule":"query-and-cache","bytes":2385,"elapsed_ms":7,"adapter":"claude"}
{"ts":"2026-08-05T14:35:43.784Z","tool":"Write","file":"apps/app/src/plugins/crossChainControllerPlugin/api/crossChainControllerService/domain/gasLimitEstimation.ts","rule":"query-and-cache","bytes":2385,"elapsed_ms":9,"adapter":"claude"}
{"ts":"2026-08-10T08:06:36.294Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerNestedActionsList/crossChainControllerNestedActionsList.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":20,"adapter":"claude"}
{"ts":"2026-08-10T08:06:52.432Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerNestedActionsList/crossChainControllerNestedActionsList.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":13,"adapter":"claude"}
{"ts":"2026-08-10T08:07:04.518Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":10,"adapter":"claude"}
{"ts":"2026-08-10T08:07:16.141Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":20,"adapter":"claude"}
{"ts":"2026-08-10T08:07:37.317Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":3,"adapter":"claude"}
{"ts":"2026-08-10T08:10:50.408Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerNestedActionsList/crossChainControllerNestedActionsList.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":5,"adapter":"claude"}
{"ts":"2026-08-10T08:10:56.137Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerNestedActionsList/crossChainControllerNestedActionsList.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":7,"adapter":"claude"}
{"ts":"2026-08-10T08:11:01.264Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerNestedActionsList/crossChainControllerNestedActionsList.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":9,"adapter":"claude"}
{"ts":"2026-08-10T08:11:07.906Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerNestedActionsList/crossChainControllerNestedActionsList.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":8,"adapter":"claude"}
{"ts":"2026-08-10T08:11:15.340Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":12,"adapter":"claude"}
{"ts":"2026-08-10T08:11:25.613Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":18,"adapter":"claude"}
{"ts":"2026-08-10T08:11:37.484Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":13,"adapter":"claude"}
{"ts":"2026-08-10T08:11:49.652Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerNestedActionsList/crossChainControllerNestedActionsList.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":17,"adapter":"claude"}
{"ts":"2026-08-10T08:11:56.129Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerNestedActionsList/crossChainControllerNestedActionsList.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":17,"adapter":"claude"}
{"ts":"2026-08-10T08:12:03.831Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":11,"adapter":"claude"}
{"ts":"2026-08-10T08:12:26.490Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":10,"adapter":"claude"}
{"ts":"2026-08-10T08:12:36.525Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.test.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":20,"adapter":"claude"}
{"ts":"2026-08-10T08:14:14.567Z","tool":"Edit","file":"apps/app/src/actions/crossChainController/components/crossChainControllerForwardMessageDetails/crossChainControllerForwardMessageDetails.tsx","rule":"core-action-decoded-input","bytes":948,"elapsed_ms":5,"adapter":"claude"}
5 changes: 5 additions & 0 deletions .changeset/app-1055-enable-download-of-nested-actions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@aragon/app": none
---

Enable downloading nested actions from the proposal actions editor and cross-chain forward message details
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { GukModulesProvider } from '@aragon/gov-ui-kit';
import { render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { encodeAbiParameters, type Hex } from 'viem';
import type { IProposalAction } from '@/modules/governance/api/governanceService';
import type { IProposalActionData } from '@/modules/governance/components/createProposalForm';
import type { IRawActionTuple } from '@/modules/governance/types';
import { proposalActionsImportExportUtils } from '@/modules/governance/utils/proposalActionsImportExportUtils';
import { forwardMessageActionsAbi } from '@/plugins/crossChainControllerPlugin/constants/crossChainControllerAbi';
import type { ICrossChainControllerActionForwardMessage } from '../../types/crossChainControllerActionForwardMessage';
import { CrossChainControllerActionType } from '../../types/enum/crossChainControllerActionType';
Expand All @@ -29,6 +31,19 @@ jest.mock('../crossChainControllerNestedActionsList', () => ({
}));

describe('<CrossChainControllerForwardMessageDetails /> component', () => {
const downloadActionsSpy = jest.spyOn(
proposalActionsImportExportUtils,
'downloadActionsAsJSON',
);

beforeEach(() => {
downloadActionsSpy.mockImplementation(() => undefined);
});

afterEach(() => {
downloadActionsSpy.mockReset();
});

const encodeMessage = (actions: IRawActionTuple[]): Hex =>
encodeAbiParameters(forwardMessageActionsAbi, [
actions.map(({ to, value, data }) => ({
Expand Down Expand Up @@ -130,6 +145,41 @@ describe('<CrossChainControllerForwardMessageDetails /> component', () => {
);
});

it('downloads the raw actions decoded from the message into a chain-scoped file', async () => {
const nestedAction = generateNestedAction();
const rawTuple = {
to: nestedAction.to,
value: nestedAction.value,
data: nestedAction.data,
};
const action = buildAction({
actions: [nestedAction],
message: encodeMessage([rawTuple]),
});

render(createTestComponent({ action }));
await userEvent.click(
screen.getByRole('button', {
name: 'app.actions.crossChainController.crossChainControllerForwardMessageDetails.downloadActions',
}),
);

expect(downloadActionsSpy).toHaveBeenCalledWith(
[rawTuple],
'cross-chain-42161-actions.json',
);
});

it('renders no download button when the message holds no actions', () => {
render(createTestComponent({ action: buildAction() }));

expect(
screen.queryByRole('button', {
name: 'app.actions.crossChainController.crossChainControllerForwardMessageDetails.downloadActions',
}),
).not.toBeInTheDocument();
});

it('renders the chain id when the destination chain is not supported by the app', () => {
const action = buildAction({ destinationChainId: 999 });

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import {
AlertInline,
Avatar,
Button,
DefinitionList,
formatterUtils,
InputContainer,
Expand All @@ -14,6 +15,7 @@ import { useMemo } from 'react';
import { decodeAbiParameters, type Hex } from 'viem';
import type { IProposalActionData } from '@/modules/governance/components/createProposalForm';
import type { IRawActionTuple } from '@/modules/governance/types';
import { proposalActionsImportExportUtils } from '@/modules/governance/utils/proposalActionsImportExportUtils';
import { forwardMessageActionsAbi } from '@/plugins/crossChainControllerPlugin/constants/crossChainControllerAbi';
import { useTranslations } from '@/shared/components/translationsProvider';
import { networkDefinitions } from '@/shared/constants/networkDefinitions';
Expand Down Expand Up @@ -94,6 +96,18 @@ export const CrossChainControllerForwardMessageDetails: React.FC<
{ format: NumberFormat.GENERIC_LONG },
);

const handleDownloadActions = () => {
const fileName =
chainId != null
? `cross-chain-${chainId.toString()}-actions.json`
: 'cross-chain-actions.json';

proposalActionsImportExportUtils.downloadActionsAsJSON(
messageActions ?? [],
fileName,
);
};

return (
<div className="flex w-full flex-col gap-y-6">
<DefinitionList.Container>
Expand Down Expand Up @@ -145,11 +159,25 @@ export const CrossChainControllerForwardMessageDetails: React.FC<
variant="warning"
/>
) : (
<CrossChainControllerNestedActionsList
chainId={chainId}
rawActions={actions}
rawTuple={messageActions}
/>
<div className="flex flex-col gap-y-4">
<CrossChainControllerNestedActionsList
chainId={chainId}
rawActions={actions}
rawTuple={messageActions}
/>
{messageActions.length > 0 && (
<Button
className="self-end"
onClick={handleDownloadActions}
size="md"
variant="tertiary"
>
{t(
'app.actions.crossChainController.crossChainControllerForwardMessageDetails.downloadActions',
)}
</Button>
)}
</div>
)}
</InputContainer>
</div>
Expand Down
3 changes: 2 additions & 1 deletion apps/app/src/assets/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
"gasLimitTerm": "Gas limit",
"actionsLabel": "Actions",
"actionsHelpText": "The actions that will be executed as a single batch on the destination chain once the message is delivered.",
"actionsDecodeError": "The forwarded message could not be decoded into actions. Check the raw calldata of this action before approving it."
"actionsDecodeError": "The forwarded message could not be decoded into actions. Check the raw calldata of this action before approving it.",
"downloadActions": "Download actions"
}
},
"gaugeRegistrar": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
generateReactQueryResultSuccess,
} from '@/shared/testUtils';
import { daoUtils } from '@/shared/utils/daoUtils';
import * as CreateProposalProvider from '../createProposalFormProvider';
import * as useDownloadProposalActionsHook from '../../../hooks/useDownloadProposalActions';
import {
CreateProposalFormActions,
type ICreateProposalFormActionsProps,
Expand All @@ -28,9 +28,9 @@ describe('<CreateProposalFormActions /> component', () => {
'useAllAllowedActions',
);
const useDialogContextSpy = jest.spyOn(DialogProvider, 'useDialogContext');
const useCreateProposalFormContextSpy = jest.spyOn(
CreateProposalProvider,
'useCreateProposalFormContext',
const useDownloadProposalActionsSpy = jest.spyOn(
useDownloadProposalActionsHook,
'useDownloadProposalActions',
);
const getDaoPluginsSpy = jest.spyOn(daoUtils, 'getDaoPlugins');

Expand All @@ -51,9 +51,10 @@ describe('<CreateProposalFormActions /> component', () => {
>,
);
useDialogContextSpy.mockReturnValue(generateDialogContext());
useCreateProposalFormContextSpy.mockReturnValue({
prepareActions: {},
addPrepareAction: jest.fn(),
useDownloadProposalActionsSpy.mockReturnValue({
isPinning: false,
hasPinErrors: false,
handleDownloadActions: jest.fn(),
});
getDaoPluginsSpy.mockReturnValue([generateDaoPlugin()]);
});
Expand All @@ -63,7 +64,7 @@ describe('<CreateProposalFormActions /> component', () => {
useAllDaoPermissionsSpy.mockReset();
useAllAllowedActionsSpy.mockReset();
useDialogContextSpy.mockReset();
useCreateProposalFormContextSpy.mockReset();
useDownloadProposalActionsSpy.mockReset();
getDaoPluginsSpy.mockReset();
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,24 +1,14 @@
import { addressUtils, type ProposalActionComponent } from '@aragon/gov-ui-kit';
import { useCallback, useState } from 'react';
import { useFormContext } from 'react-hook-form';
import { useAllAllowedActions } from '@/modules/governance/api/executeSelectorsService';
import type { IProposalAction } from '@/modules/governance/api/governanceService';
import { useAllDaoPermissions, useDao } from '@/shared/api/daoService';
import { useTranslations } from '@/shared/components/translationsProvider';
import { useDaoChain } from '@/shared/hooks/useDaoChain';
import { daoUtils } from '@/shared/utils/daoUtils';
import { monitoringUtils } from '@/shared/utils/monitoringUtils';
import type { IProposalCreateAction } from '../../../dialogs/publishProposalDialog';
import { useDownloadProposalActions } from '../../../hooks/useDownloadProposalActions';
import { useProposalActionsField } from '../../../hooks/useProposalActionsField';
import { proposalActionPreparationUtils } from '../../../utils/proposalActionPreparationUtils';
import { proposalActionsImportExportUtils } from '../../../utils/proposalActionsImportExportUtils';
import { ActionComposer, actionComposerUtils } from '../../actionComposer';
import { ProposalActionsEditList } from '../../proposalActionsEditList';
import type {
ICreateProposalFormData,
IProposalActionData,
} from '../createProposalFormDefinitions';
import { useCreateProposalFormContext } from '../createProposalFormProvider';
import type { IProposalActionData } from '../createProposalFormDefinitions';
import { coreCustomActionComponents } from './coreCustomActionComponents';

export interface ICreateProposalFormActionsProps {
Expand Down Expand Up @@ -64,10 +54,6 @@ export const CreateProposalFormActions: React.FC<
const { t } = useTranslations();
const { chainId } = useDaoChain({ daoId });

const { getValues } = useFormContext<ICreateProposalFormData>();

const { prepareActions } = useCreateProposalFormContext();

const {
actionsMerged,
handleAddAction,
Expand All @@ -83,40 +69,8 @@ export const CreateProposalFormActions: React.FC<
urlParams: { network: dao!.network, daoAddress: targetDaoAddress },
});

const [isDownloadPinning, setIsDownloadPinning] = useState(false);
const [hasDownloadPinErrors, setHasDownloadPinErrors] = useState(false);

const handleDownloadActions = useCallback(async () => {
setIsDownloadPinning(true);
setHasDownloadPinErrors(false);

try {
const currentActions = getValues('actions') ?? [];

// Prepare actions using registered prepare functions
const preparedActions =
await proposalActionPreparationUtils.prepareActions({
actions: currentActions as IProposalCreateAction[],
prepareActions,
});

proposalActionsImportExportUtils.downloadActionsAsJSON(
preparedActions as unknown as IProposalAction[],
`dao-${daoId}-actions.json`,
);
} catch (error) {
monitoringUtils.logError(error, {
context: {
daoId,
message:
'Failed to pin or download proposal actions for DAO',
},
});
setHasDownloadPinErrors(true);
} finally {
setIsDownloadPinning(false);
}
}, [daoId, getValues, prepareActions]);
const { isPinning, hasPinErrors, handleDownloadActions } =
useDownloadProposalActions({ daoId });

const { pluginComponents } = actionComposerUtils.getDaoPluginActions(dao);
const { components: permissionActionComponents } =
Expand Down Expand Up @@ -153,8 +107,8 @@ export const CreateProposalFormActions: React.FC<
daoId={targetDaoId}
daoPermissions={daoPermissions}
hasActions={hasActions}
hasPinErrors={hasDownloadPinErrors}
isPinning={isDownloadPinning}
hasPinErrors={hasPinErrors}
isPinning={isPinning}
onAddAction={handleAddAction}
onDownloadActions={handleDownloadActions}
onRemoveAllActions={handleRemoveAllActions}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
} from '@/shared/api/daoService';
import { useTranslations } from '@/shared/components/translationsProvider';
import { useDaoChain } from '@/shared/hooks/useDaoChain';
import { useDownloadProposalActions } from '../../hooks/useDownloadProposalActions';
import { useProposalActionsField } from '../../hooks/useProposalActionsField';
import { ActionComposer, actionComposerUtils } from '../actionComposer';
import type { IProposalActionData } from '../createProposalForm';
Expand Down Expand Up @@ -62,6 +63,9 @@ export const ProposalActionsEditor: React.FC<IProposalActionsEditorProps> = (
getArrayControls,
} = useProposalActionsField();

const { isPinning, hasPinErrors, handleDownloadActions } =
useDownloadProposalActions({ daoId });

const { data: daoPermissions } = useAllDaoPermissions(
{
urlParams: {
Expand Down Expand Up @@ -108,8 +112,11 @@ export const ProposalActionsEditor: React.FC<IProposalActionsEditorProps> = (
daoPermissions={daoPermissions}
excludeActionTypes={excludeActionTypes}
hasActions={hasActions}
hasPinErrors={hasPinErrors}
isPinning={isPinning}
network={network}
onAddAction={handleAddAction}
onDownloadActions={handleDownloadActions}
onRemoveAllActions={handleRemoveAllActions}
/>
) : (
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export {
type IUseDownloadProposalActionsParams,
useDownloadProposalActions,
} from './useDownloadProposalActions';
Loading
Loading