Skip to content

feat(APP-1032): Implement action decoding/details view (9/10) - #1309

Open
milosh86 wants to merge 5 commits into
app-1054-implement-gaslimit-paramfrom
app-1032-implement-action-decodingdetails-view
Open

feat(APP-1032): Implement action decoding/details view (9/10)#1309
milosh86 wants to merge 5 commits into
app-1054-implement-gaslimit-paramfrom
app-1032-implement-action-decodingdetails-view

Conversation

@milosh86

@milosh86 milosh86 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

Closes APP-1032.

Adds the read-only details view for a forwardMessage action rendered back from a proposal, using the app's
actionViewRegistry (CrossChainControllerActionType.CROSS_CHAIN_EXECUTE).

  • CrossChainControllerExecuteActionDetails shows the destination chain (name + logo, resolved from chainId via
    networkUtils.getNetworkByChainId, falling back to Chain {chainId} for unsupported chains) and the gas limit, then
    re-decodes the _message payload's Action[] tuple itself (forwardMessageActionsAbi, now shared with the create
    view instead of duplicated) to check the backend-decoded sub-actions against.
  • CrossChainControllerNestedActionsList renders those sub-actions with ProposalActions.Item directly — unlike the
    generic NestedActionsList, it does not resolve a plugin-specific component for them, since the DAO's own network
    and installed plugins belong to the origin chain, not the destination chain the actions execute on.
  • proposalActionUtils.resolveNestedActions / buildRawActionStubs — lifted out of NestedActionsList (now just a
    thin caller) so both the generic and cross-chain lists share the same raw-tuple-vs-decoded-length fallback logic.
  • IRawActionTuple moved to modules/governance/types as a shared type instead of being declared locally in
    NestedActionsList.

Dependencies: stacked on app-1054-implement-gaslimit-paramapp-1056-…app-1053-…main. Merge the bases
first.

Type of Change

  • Minor: Feature (non-breaking change which adds new functionality)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github's UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@linear-code

linear-code Bot commented Aug 7, 2026

Copy link
Copy Markdown

APP-1032

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-8jedkev7t-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 82 passed
HTML report View report
GitHub job ✅ completed

View run #4918

@milosh86 milosh86 changed the title app 1032 implement action decodingdetails view feat(APP-1032): Implement action decoding/details view (9/10) Aug 7, 2026
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
milosh86 force-pushed the app-1032-implement-action-decodingdetails-view branch from 21ed840 to 955e2a9 Compare August 7, 2026 12:42
@milosh86
milosh86 marked this pull request as ready for review August 7, 2026 13:34
@milosh86
milosh86 requested a review from a team as a code owner August 7, 2026 13:34
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant