feat(APP-1032): Implement action decoding/details view (9/10) - #1309
Open
milosh86 wants to merge 5 commits into
Open
feat(APP-1032): Implement action decoding/details view (9/10)#1309milosh86 wants to merge 5 commits into
milosh86 wants to merge 5 commits into
Conversation
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
milosh86
force-pushed
the
app-1032-implement-action-decodingdetails-view
branch
from
August 7, 2026 12:42
21ed840 to
955e2a9
Compare
…ent-action-decodingdetails-view
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes APP-1032.
Adds the read-only details view for a
forwardMessageaction rendered back from a proposal, using the app'sactionViewRegistry(CrossChainControllerActionType.CROSS_CHAIN_EXECUTE).CrossChainControllerExecuteActionDetailsshows the destination chain (name + logo, resolved fromchainIdvianetworkUtils.getNetworkByChainId, falling back toChain {chainId}for unsupported chains) and the gas limit, thenre-decodes the
_messagepayload'sAction[]tuple itself (forwardMessageActionsAbi, now shared with the createview instead of duplicated) to check the backend-decoded sub-actions against.
CrossChainControllerNestedActionsListrenders those sub-actions withProposalActions.Itemdirectly — unlike thegeneric
NestedActionsList, it does not resolve a plugin-specific component for them, since the DAO's own networkand installed plugins belong to the origin chain, not the destination chain the actions execute on.
proposalActionUtils.resolveNestedActions/buildRawActionStubs— lifted out ofNestedActionsList(now just athin caller) so both the generic and cross-chain lists share the same raw-tuple-vs-decoded-length fallback logic.
IRawActionTuplemoved tomodules/governance/typesas a shared type instead of being declared locally inNestedActionsList.Dependencies: stacked on
app-1054-implement-gaslimit-param→app-1056-…→app-1053-…→main. Merge the basesfirst.
Type of Change
Developer Checklist:
Review Checklist: