fix: Fix stale watched action data overwriting proposal actions after remove/add - #1306
Closed
milosh86 wants to merge 1 commit into
Closed
fix: Fix stale watched action data overwriting proposal actions after remove/add#1306milosh86 wants to merge 1 commit into
milosh86 wants to merge 1 commit into
Conversation
… remove/add Signed-off-by: Milos Dzepina <milos@aragon.org>
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useFieldArray'sfieldsupdate synchronously insideremove()/append(), butuseWatchonly catches up a render later. Comparing array length alone isn't enough to detect that lag: deleting one action and adding a different one leaves the array length unchanged, so a stalewatchedActiondescribing the just-deleted action can slip through — overwriting the new action'stypeand silently mounting the wrong view populated with the previous action's data.This replaces the length-based staleness check with a
fieldIdcomparison (unique per action instance), which catches the lag even when the length coincidentally matches again.Type of Change
Developer Checklist:
Review Checklist: