feat(APP-667): Pull token voting ERC20 members from aragon-subdomain

.changeset/app-667-token-voting-members-from-aragon-domain.md

@@ -0,0 +1,5 @@
+---
+"@aragon/app": minor
+---
+
+Serve mainnet ERC-20 token-voting member lists from the aragon-domain (Envio) BFF, with source routing and a legacy-backend fallback

apps/app/package.json

@@ -30,7 +30,7 @@
         "e2e:codegen": "playwright codegen --config e2e/playwright.config.ts"
     },
     "dependencies": {
-        "@aragon/aragon-domain": "^0.3.1",
+        "@aragon/aragon-domain": "0.0.0-20260806160246",
         "@aragon/assistant-chat": "workspace:*",
         "@aragon/assistant-contracts": "workspace:*",
         "@aragon/gov-ui-kit": "catalog:",

apps/app/src/app/api/domain/token-voting/members/route.test.ts

@@ -0,0 +1,83 @@
+/** @jest-environment node */
+
+import type { NextRequest } from 'next/server';
+import { tokenVotingMembershipServiceServer } from '@/modules/governance/api/tokenVotingMembershipService/tokenVotingMembershipService.server';
+import { GET } from './route';
+
+const pluginAddress = '0x1111111111111111111111111111111111111111';
+const tokenContractAddress = '0x2222222222222222222222222222222222222222';
+
+const generateRequest = (query: string): NextRequest =>
+    ({
+        nextUrl: new URL(
+            `http://localhost/api/domain/token-voting/members?${query}`,
+        ),
+    }) as NextRequest;
+
+describe('GET /api/domain/token-voting/members', () => {
+    const getMembershipSpy = jest.spyOn(
+        tokenVotingMembershipServiceServer,
+        'getTokenVotingMembership',
+    );
+
+    afterEach(() => {
+        getMembershipSpy.mockReset();
+    });
+
+    it.each([
+        [
+            'a missing plugin address',
+            `tokenContractAddress=${tokenContractAddress}`,
+        ],
+        [
+            'an invalid plugin address',
+            `pluginAddress=not-an-address&tokenContractAddress=${tokenContractAddress}`,
+        ],
+        [
+            'an invalid token contract address',
+            `pluginAddress=${pluginAddress}&tokenContractAddress=0x1234`,
+        ],
+        [
+            'a non-integer page',
+            `pluginAddress=${pluginAddress}&tokenContractAddress=${tokenContractAddress}&page=first`,
+        ],
+        [
+            'a non-positive page size',
+            `pluginAddress=${pluginAddress}&tokenContractAddress=${tokenContractAddress}&pageSize=0`,
+        ],
+        [
+            'a page size above the domain maximum',
+            `pluginAddress=${pluginAddress}&tokenContractAddress=${tokenContractAddress}&pageSize=251`,
+        ],
+    ])('returns 400 for %s', async (_label, query) => {
+        const response = await GET(generateRequest(query));
+
+        expect(response.status).toBe(400);
+        expect(getMembershipSpy).not.toHaveBeenCalled();
+    });
+
+    it('passes validated request parameters to the domain service', async () => {
+        const result = {
+            data: [],
+            metadata: { page: 2, pageSize: 25, totalPages: 0, totalRecords: 0 },
+        };
+        getMembershipSpy.mockResolvedValue(result);
+
+        const response = await GET(
+            generateRequest(
+                `pluginAddress=${pluginAddress}&tokenContractAddress=${tokenContractAddress}&page=2&pageSize=25`,
+            ),
+        );
+
+        expect(response.status).toBe(200);
+        expect(getMembershipSpy).toHaveBeenCalledWith({
+            queryParams: {
+                pluginAddress,
+                tokenContractAddress,
+                page: 2,
+                pageSize: 25,
+            },
+        });
+        await expect(response.json()).resolves.toEqual(result);
+    });
+});

apps/app/src/app/api/domain/token-voting/members/route.ts

@@ -0,0 +1,82 @@
+import { type NextRequest, NextResponse } from 'next/server';
+// biome-ignore lint/style/noRestrictedImports: server-only BFF validation; strict EIP-55 validation is explicitly disabled.
+import { isAddress } from 'viem';
+import { tokenVotingMembershipServiceServer } from '@/modules/governance/api/tokenVotingMembershipService/tokenVotingMembershipService.server';
+import { monitoringUtils } from '@/shared/utils/monitoringUtils';
+
+const maximumPageSize = 250;
+
+interface ITokenVotingMembershipQueryParams {
+    pluginAddress: string;
+    tokenContractAddress: string;
+    page?: number;
+    pageSize?: number;
+}
+
+const validateQueryParams = (
+    params: URLSearchParams,
+): ITokenVotingMembershipQueryParams | undefined => {
+    const pluginAddress = params.get('pluginAddress');
+    const tokenContractAddress = params.get('tokenContractAddress');
+    const page = params.get('page');
+    const pageSize = params.get('pageSize');
+    const parsedPage = page != null ? Number(page) : undefined;
+    const parsedPageSize = pageSize != null ? Number(pageSize) : undefined;
+
+    if (
+        pluginAddress == null ||
+        tokenContractAddress == null ||
+        !isAddress(pluginAddress, { strict: false }) ||
+        !isAddress(tokenContractAddress, { strict: false }) ||
+        (parsedPage != null &&
+            (!Number.isInteger(parsedPage) || parsedPage <= 0)) ||
+        (parsedPageSize != null &&
+            (!Number.isInteger(parsedPageSize) ||
+                parsedPageSize <= 0 ||
+                parsedPageSize > maximumPageSize))
+    ) {
+        return;
+    }
+
+    return {
+        pluginAddress,
+        tokenContractAddress,
+        page: parsedPage,
+        pageSize: parsedPageSize,
+    };
+};
+
+export const GET = async (req: NextRequest) => {
+    const queryParams = validateQueryParams(req.nextUrl.searchParams);
+
+    if (queryParams == null) {
+        return NextResponse.json(
+            {
+                error: 'pluginAddress and tokenContractAddress must be valid addresses; page must be a positive integer; pageSize must be a positive integer no greater than 250',
+            },
+            { status: 400 },
+        );
+    }
+
+    try {
+        const result =
+            await tokenVotingMembershipServiceServer.getTokenVotingMembership({
+                queryParams,
+            });
+
+        return NextResponse.json(result);
+    } catch (error) {
+        monitoringUtils.logError(error, {
+            context: {
+                errorType: 'get_token_voting_membership_error',
+                pluginAddress: queryParams.pluginAddress,
+                tokenContractAddress: queryParams.tokenContractAddress,
+            },
+        });
+
+        return NextResponse.json(
+            { error: 'getTokenVotingMembership request failed' },
+            { status: 500 },
+        );
+    }
+};

apps/app/src/app/dao/[network]/[addressOrEns]/(daoPage)/members/page.tsx

@@ -1,3 +1,5 @@
-import { DaoMembersPage } from '@/modules/governance/pages/daoMembersPage';
+// Imported from the page file (not the module barrel): the RSC pulls in
+// server-only prefetch code that must stay out of the barrel's client graph.
+import { DaoMembersPage } from '@/modules/governance/pages/daoMembersPage/daoMembersPage';
 
 export default DaoMembersPage;

apps/app/src/modules/application/api/memberProfileService/memberProfileService.server.ts

@@ -4,10 +4,9 @@ import type { IGetEnsTextRecordsParams } from './memberProfileService.api';
 
 class MemberProfileServiceServer {
     getEnsTextRecords = async ({ urlParams }: IGetEnsTextRecordsParams) => {
-        const result =
-            await aragonDomainServiceBackend.getMemberProfileTextRecords(
-                urlParams,
-            );
+        const result = await aragonDomainServiceBackend
+            .getDomain()
+            .getMemberProfileTextRecords(urlParams);
 
         if (!result.success) {
             throw new Error(

apps/app/src/modules/governance/api/governanceService/governanceService.api.ts

@@ -2,7 +2,7 @@ import type {
     IOrderedRequest,
     IPaginatedRequest,
 } from '@/shared/api/aragonBackendService';
-import type { Network } from '@/shared/api/daoService';
+import type { Network, PluginInterfaceType } from '@/shared/api/daoService';
 import type {
     IRequestQueryParams,
     IRequestUrlParams,
@@ -59,6 +59,32 @@ export interface IGetMemberListQueryParams extends IPaginatedRequest {
 export interface IGetMemberListParams
     extends IRequestQueryParams<IGetMemberListQueryParams> {}
 
+export interface IGetTokenVotingMembershipQueryParams
+    extends IGetMemberListQueryParams {
+    /**
+     * Network of the plugin, used to route the query to the aragon-domain BFF
+     * when the network is indexed by Envio.
+     */
+    network?: Network;
+    /**
+     * Interface type of the plugin.
+     */
+    pluginInterfaceType?: PluginInterfaceType;
+    /**
+     * Address of the governance token.
+     */
+    tokenAddress?: string;
+    /**
+     * Address of the underlying token when the governance token is a wrapped
+     * or voting-escrow adapter. `null` / `undefined` means the governance
+     * token is a plain ERC-20.
+     */
+    tokenUnderlying?: string | null;
+}
+
+export interface IGetTokenVotingMembershipParams
+    extends IRequestQueryParams<IGetTokenVotingMembershipQueryParams> {}
+
 export interface IGetMemberUrlParams {
     /**
      * Address of a DAO member.