Repository navigation
fix(account): Load more keeps a stale history stale; no "0y ago" - #168
Merged
Merged
Conversation
- A successful Load more cleared the stale mark and stamped the history "just now", though page one still predated the top-up. Each page now carries its fetch time and the age reads page one's; Load more restores the invalidation if it was set before or during the fetch (CodeRabbit). - relativeTime returned "0y ago" for 360-364 days (twelve 30-day months, not yet a year); it now caps at 11mo (CodeRabbit). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LxLDipDTwGmYw9bgV4cjoJ
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings CodeRabbit raised on the release PR (#167), fixed before 4.11.3 ships.
fetchedAtand the age reads page one's; Load more restores the invalidation if it was set before or during the fetch (watched via the query cache'sinvalidateevents).relativeTimesaid "0y ago" for 360–364 days (twelve 30-day months, not yet a year). Now caps at "11mo ago". Pre-existing; shows in the history line and ArNS target descriptions.Checks
lint,npm test(87 files, 1464 tests; new relativeTime case).refresh-balance, Load more → 3 rows, nudge and "6m ago" kept); Account 30/30.🤖 Generated with Claude Code
https://claude.ai/code/session_01LxLDipDTwGmYw9bgV4cjoJ