Remove leaking of tracks and replace it by construction from steps#540
Draft
SeverinDiederichs wants to merge 8 commits intoapt-sim:masterfrom
Draft
Remove leaking of tracks and replace it by construction from steps#540SeverinDiederichs wants to merge 8 commits intoapt-sim:masterfrom
SeverinDiederichs wants to merge 8 commits intoapt-sim:masterfrom
Conversation
…failing histograms
…ns as Steps and not as Tracks
…ommit: replace all leaked tracks with returning GPUHits
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #539 and should not be reviewed before that one is merged.
This PR extends the idea to use the GPUHits to create the tracks for nuclear reactions to use it for all leaked tracks.
This has the following consequences:
Regarding performance:
To Do:
It was verified that this PR