Skip to content

Remove leaking of tracks and replace it by construction from steps#540

Draft
SeverinDiederichs wants to merge 8 commits intoapt-sim:masterfrom
SeverinDiederichs:replace_leakingtracks_by_steps
Draft

Remove leaking of tracks and replace it by construction from steps#540
SeverinDiederichs wants to merge 8 commits intoapt-sim:masterfrom
SeverinDiederichs:replace_leakingtracks_by_steps

Conversation

@SeverinDiederichs
Copy link
Copy Markdown
Collaborator

This PR is a follow up to #539 and should not be reviewed before that one is merged.

This PR extends the idea to use the GPUHits to create the tracks for nuclear reactions to use it for all leaked tracks.
This has the following consequences:

  • all leaked tracks related machinery is removed, drastically simplifying the state machine, the asynchronous GPU transport loop, the interfaces
  • the deferred nuclear steps and leaked tracks can now be treated as the same again and the sorting is simplified

Regarding performance:

  • sending back leaked tracks is cheaper than steps. Therefore, this new implementation can be a) cheaper if a step + a track were sent back, b) more expensive before only a track was sent back, as the step is bigger.
  • simplifying the state machine and removing synchronizations should not really make a difference, as the leaks were usually not the problem.

To Do:

  • run test in full Athena to see for the performance

It was verified that this PR

@SeverinDiederichs SeverinDiederichs added the cleaning improves code clarity, readability or other label Apr 9, 2026
@phsft-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@SeverinDiederichs SeverinDiederichs marked this pull request as draft April 10, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleaning improves code clarity, readability or other

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants