[images]: fix image load error to write to stderr and use FilePath#1570
Merged
Conversation
jglogan
requested changes
May 17, 2026
68d0285 to
3b584a3
Compare
jglogan
approved these changes
May 18, 2026
jglogan
requested changes
May 18, 2026
Contributor
jglogan
left a comment
There was a problem hiding this comment.
See note about force try on L70
9ce9bbe to
e6b5a82
Compare
e6b5a82 to
8294ab0
Compare
jglogan
requested changes
May 18, 2026
Contributor
jglogan
left a comment
There was a problem hiding this comment.
See suggestion to cut this over to FilePath. We can do ImageSave in a follow-up issue
saehejkang
commented
May 19, 2026
Code Coverage
|
jglogan
approved these changes
May 20, 2026
Open
1 task
PeteHaughie
pushed a commit
to PeteHaughie/apple-container
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #1535
Closes #1573
Testing