Skip to content

[images]: fix image load error to write to stderr and use FilePath#1570

Merged
jglogan merged 2 commits into
apple:mainfrom
saehejkang:fix-image-load-to-output-stderr
May 20, 2026
Merged

[images]: fix image load error to write to stderr and use FilePath#1570
jglogan merged 2 commits into
apple:mainfrom
saehejkang:fix-image-load-to-output-stderr

Conversation

@saehejkang
Copy link
Copy Markdown
Contributor

@saehejkang saehejkang commented May 17, 2026

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Closes #1535
Closes #1573

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

Comment thread Sources/ContainerCommands/Image/ImageLoad.swift Outdated
@saehejkang saehejkang force-pushed the fix-image-load-to-output-stderr branch from 68d0285 to 3b584a3 Compare May 17, 2026 21:15
Comment thread Sources/ContainerCommands/Image/ImageLoad.swift Outdated
Copy link
Copy Markdown
Contributor

@jglogan jglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note about force try on L70

@saehejkang saehejkang force-pushed the fix-image-load-to-output-stderr branch 3 times, most recently from 9ce9bbe to e6b5a82 Compare May 18, 2026 03:36
@saehejkang saehejkang force-pushed the fix-image-load-to-output-stderr branch from e6b5a82 to 8294ab0 Compare May 18, 2026 03:36
Copy link
Copy Markdown
Contributor

@jglogan jglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion to cut this over to FilePath. We can do ImageSave in a follow-up issue

Comment thread Sources/ContainerCommands/Image/ImageLoad.swift Outdated
Comment thread Sources/ContainerCommands/Image/ImageLoad.swift
@saehejkang saehejkang changed the title [images]: fix image load error to write to stderr [images]: fix image load error to write to stderr and use FilePath May 19, 2026
@github-actions
Copy link
Copy Markdown

Code Coverage

Tier Line Coverage
Unit 34.09%
Integration 20.23%
Combined 53.75%

@jglogan jglogan merged commit 4f097eb into apple:main May 20, 2026
3 checks passed
PeteHaughie pushed a commit to PeteHaughie/apple-container that referenced this pull request May 20, 2026
@saehejkang saehejkang deleted the fix-image-load-to-output-stderr branch May 21, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: TECH DEBT: Convert image load/save to use FilePath [Bug]: container image load -i <missing-file> writes the error to stdout

2 participants