cli: Add support for --stop-signal#1462
Merged
Merged
Conversation
saehejkang
reviewed
Apr 29, 2026
Contributor
There was a problem hiding this comment.
should this be updated now as well?
saehejkang
reviewed
Apr 29, 2026
Member
Author
There was a problem hiding this comment.
I'd prefer them to be strings as well, but I'd rather do in a follow-up.
This adds stop signal support to the cli. The priority is: 1. If an explicit stop signal is passed on the cli use this. 2. If not, check if there is a stop signal in the image config. 3. Finally, use the default (TERM).
Code Coverage
|
jglogan
reviewed
May 22, 2026
| ) | ||
|
|
||
| public init(timeoutInSeconds: Int32, signal: Int32) { | ||
| public init(timeoutInSeconds: Int32, signal: String?) { |
Contributor
There was a problem hiding this comment.
Can we do validation in this type so that it's correct on construction?
Does this type really need to be mutable (I do see it makes resolvedOptions slightly easier below)?
jglogan
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1581.
This adds stop signal support to the cli. The priority is: