Skip to content

DTT-GHA - #100

Merged
adrianmartin23 merged 64 commits into
masterfrom
ddt-gha
Jan 30, 2026
Merged

adrianmartin23 merged 64 commits into
masterfrom
ddt-gha

Conversation

@ARoldan-deloitte

Copy link
Copy Markdown
Contributor

No description provided.

@ARoldan-deloitte
ARoldan-deloitte requested a review from a team as a code owner January 19, 2026 11:05
set -e
aws s3 cp --quiet ${s3Path} cache.tar.gz --profile AplazameSharedServices || exit 0
[ -f cache.tar.gz ] && tar -xf cache.tar.gz
aws s3 cp --quiet ${s3Path} cache.tar.gz --profile AplazameSharedServices

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comando repetido

Comment thread .github/workflows/sonar-and-test-S3.yaml
Comment thread .github/workflows/sonar-and-test-S3.yaml
aws s3 cp --acl public-read aplazame.latest.zip s3://aplazame/modules/prestashop/ --profile Aplazame

- name: Await Manual Approval
if: ${{ github.event_name == 'push' }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y que sea en la rama master

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigue sin resolverse

Comment thread .github/workflows/sonar-and-test-S3.yaml
Comment thread .github/workflows/sonar-and-test-S3.yaml
with:
secret: ${{ secrets.AP_GH_RELEASE_TOKEN_OLD }}
minimum-approvals: 1
approvers: 'AR40873_wzk'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usuario incorrecto

if: ${{ github.event_name == 'push' }}
uses: trstringer/manual-approval@v1
with:
secret: ${{ secrets.AP_GH_RELEASE_TOKEN_OLD }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token incorrecto, usar ${{ github.TOKEN }}

uses: SonarSource/sonarqube-scan-action@a31c9398be7ace6bbfaf30c0bd5d415f843d45e9 #v7.0.0
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
#SONAR_HOST_URL: ${{ vars.SONAR_HOST_URL }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eliminar si no va a ser usado

run: make syntax.checker

- name: CS Style
if: github.ref == 'refs/heads/master'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No está bien

@adrianmartin23
adrianmartin23 merged commit 33d9419 into master Jan 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants