Skip to content

[SPARK-56449][INFRA] Skip pre-flight checks for code questions in AGENTS.md #55303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szehon-ho wants to merge 3 commits into from
+3 −3
Closed

[SPARK-56449][INFRA] Skip pre-flight checks for code questions in AGENTS.md #55303

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2194436
[SPARK-56449][INFRA] Skip pre-flight checks for code questions in AGE…
szehon-ho Apr 11, 2026
e261a87
Address review: simplify pre-flight skip to a single line change
szehon-ho Apr 14, 2026
84daa30
Apply suggestion from @cloud-fan
cloud-fan Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@

## Pre-flight Checks

Before the first code read, edit, or test in a session, ensure a clean working environment. DO NOT skip these checks:
These checks apply to all tasks **except** answering questions about the code or its behavior. For those, skip these checks and work directly on whatever branch is currently checked out.
Copy link
Copy Markdown
Contributor

@cloud-fan cloud-fan Apr 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I think there is ambiguity here: do users want to ask questions about the code of latest master branch, or the current (may be dirty) local branch? Both are possible, but I think do not disturb the current branch is a better default. So +1 to your proposal.

Shall we just make a single change? Before the first code edit or running test in a session, ..

Copy link
Copy Markdown
Member Author

@szehon-ho szehon-ho Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done, thanks!


Before the first edit or test in a session, ensure a clean working environment. DO NOT skip these checks:

1. Run `git remote -v` to identify the personal fork and upstream (`apache/spark`). If unclear, ask the user to configure their remotes following the standard convention (`origin` for the fork, `upstream` for `apache/spark`).
2. If the latest commit on `<upstream>/master` is more than a day old (check with `git log -1 --format="%ci" <upstream>/master`), run `git fetch <upstream> master`.
3. If there are uncommitted changes (check with `git status`), ask the user to stash them before proceeding.
4. Switch to the appropriate branch:
- **Existing PR**: resolve the PR branch name via `gh api repos/databricks-eng/runtime/pulls/<number> --jq '.head.ref'`, then look for a local branch matching that name. If found, switch to it and inform the user. If not found, ask whether to fetch it or if there is a local branch under a different name.
Copy link
Copy Markdown
Contributor

@peter-toth peter-toth Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that gh api repos/databricks-eng/runtime/pulls/<number> wasn't added in this PR, but maybe we should fix it here.

Copy link
Copy Markdown
Contributor

@cloud-fan cloud-fan Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, let's fix it. @szehon-ho

Comment thread
cloud-fan marked this conversation as resolved.
Outdated
- **New edits**: ask the user to choose: create a new git worktree from `<upstream>/master` and work from there (recommended), or create and switch to a new branch from `<upstream>/master`.
- **Reading code or running tests**: use `<upstream>/master`.
- **Running tests**: use `<upstream>/master`.

## Development Notes

Expand Down