-
Notifications
You must be signed in to change notification settings - Fork 823
Text to vector refactoring #4375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nicolo-rinaldi
wants to merge
9
commits into
apache:main
Choose a base branch
from
SeaseLtd:text-to-vector-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2136650
[text-to-vector-refactoring] Refactoring to accomodate future new fea…
nicolo-rinaldi 4c86f35
[text-to-vector-refactoring] Quick fixes ported from review of docume…
nicolo-rinaldi 86949b3
[text-to-vector-refactoring] Quick fixes ported from review of docume…
nicolo-rinaldi 54529af
Merge branch 'main' into text-to-vector-refactoring
nicolo-rinaldi 11bb601
[language-model-refactoring] Pre-check changes
nicolo-rinaldi 56a4db4
[text-to-vector-refactoring] Addressing Anna's comments
nicolo-rinaldi de3328f
[text-to-vector-refactoring] Addressing Anna's comments
nicolo-rinaldi f9f8292
[text-to-vector-refactoring] Renamed generics into more meaningful ones
nicolo-rinaldi 11494d6
[text-to-vector-refactoring] Moved class LanguageModelStore into an i…
nicolo-rinaldi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
48 changes: 48 additions & 0 deletions
48
...ules/language-models/src/java/org/apache/solr/languagemodels/model/SolrLanguageModel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.solr.languagemodels.model; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Base class for Solr-managed wrappers around langchain4j used in {@code language-models} module | ||
| */ | ||
| public abstract class SolrLanguageModel { | ||
|
|
||
| // common parameters | ||
| protected static final String TIMEOUT_PARAM = "timeout"; | ||
| protected static final String MAX_RETRIES_PARAM = "maxRetries"; | ||
|
|
||
| protected final String name; | ||
| protected final Map<String, Object> params; | ||
|
|
||
| protected SolrLanguageModel(String name, Map<String, Object> params) { | ||
| this.name = name; | ||
| this.params = params; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public Map<String, Object> getParams() { | ||
| return params; | ||
| } | ||
|
|
||
| /** Returns the class name of the underlying langchain4j model instance. */ | ||
| public abstract String getModelClassName(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
solr/modules/language-models/src/java/org/apache/solr/languagemodels/store/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** Contains model store related classes. */ | ||
| package org.apache.solr.languagemodels.store; |
156 changes: 156 additions & 0 deletions
156
...language-models/src/java/org/apache/solr/languagemodels/store/rest/ManagedModelStore.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.solr.languagemodels.store.rest; | ||
|
|
||
| import java.lang.invoke.MethodHandles; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.stream.Collectors; | ||
| import net.jcip.annotations.ThreadSafe; | ||
| import org.apache.solr.common.SolrException; | ||
| import org.apache.solr.common.util.NamedList; | ||
| import org.apache.solr.core.SolrResourceLoader; | ||
| import org.apache.solr.languagemodels.model.SolrLanguageModel; | ||
| import org.apache.solr.languagemodels.store.LanguageModelException; | ||
| import org.apache.solr.languagemodels.store.LanguageModelStore; | ||
| import org.apache.solr.response.SolrQueryResponse; | ||
| import org.apache.solr.rest.BaseSolrResource; | ||
| import org.apache.solr.rest.ManagedResource; | ||
| import org.apache.solr.rest.ManagedResourceStorage; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * Abstract base class for {@link ManagedResource} wrappers that expose a {@link LanguageModelStore} | ||
| * via the REST API. Concrete subclasses supply the REST endpoint and the model instantiation logic. | ||
| */ | ||
| @ThreadSafe | ||
| public abstract class ManagedModelStore<M extends SolrLanguageModel> extends ManagedResource | ||
|
nicolo-rinaldi marked this conversation as resolved.
Outdated
|
||
| implements ManagedResource.ChildResourceSupport { | ||
| private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); | ||
|
|
||
| private static final String MODELS_JSON_FIELD = "models"; | ||
|
|
||
| protected static final String CLASS_KEY = "class"; | ||
| protected static final String NAME_KEY = "name"; | ||
| protected static final String PARAMS_KEY = "params"; | ||
|
|
||
| private final LanguageModelStore<M> store; | ||
| private Object managedData; | ||
|
|
||
| protected ManagedModelStore( | ||
| String resourceId, SolrResourceLoader loader, ManagedResourceStorage.StorageIO storageIO) | ||
| throws SolrException { | ||
| super(resourceId, loader, storageIO); | ||
| store = new LanguageModelStore<>(); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a model instance from the JSON map persisted in the managed resource storage. | ||
| * | ||
| * @param loader the resource loader for the current core | ||
| * @param modelMap a map containing {@code "class"}, {@code "name"}, and {@code "params"} keys | ||
| * @return the instantiated model | ||
| */ | ||
| protected abstract M fromModelMap(SolrResourceLoader loader, Map<String, Object> modelMap); | ||
|
|
||
| private static LinkedHashMap<String, Object> toModelMap(SolrLanguageModel model) { | ||
| final LinkedHashMap<String, Object> modelMap = new LinkedHashMap<>(3, 1.0f); | ||
| modelMap.put(NAME_KEY, model.getName()); | ||
| modelMap.put(CLASS_KEY, model.getModelClassName()); | ||
| modelMap.put(PARAMS_KEY, model.getParams()); | ||
| return modelMap; | ||
| } | ||
|
|
||
| @Override | ||
| protected void onManagedDataLoadedFromStorage(NamedList<?> managedInitArgs, Object managedData) | ||
| throws SolrException { | ||
| store.clear(); | ||
| this.managedData = managedData; | ||
| } | ||
|
|
||
| public void loadStoredModels() { | ||
| log.info("------ managed models ~ loading ------"); | ||
| if ((managedData != null) && (managedData instanceof List)) { | ||
| @SuppressWarnings("unchecked") | ||
| final List<Map<String, Object>> models = (List<Map<String, Object>>) managedData; | ||
| for (final Map<String, Object> model : models) { | ||
| addModelFromMap(model); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private void addModelFromMap(Map<String, Object> modelMap) { | ||
| try { | ||
| addModel(fromModelMap(solrResourceLoader, modelMap)); | ||
| } catch (final LanguageModelException e) { | ||
| throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, e); | ||
| } | ||
| } | ||
|
|
||
| public void addModel(M model) throws SolrException { | ||
| try { | ||
| if (log.isInfoEnabled()) { | ||
| log.info("adding model {}", model.getName()); | ||
| } | ||
| store.addModel(model); | ||
| } catch (final LanguageModelException e) { | ||
| throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, e); | ||
| } | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| @Override | ||
| protected Object applyUpdatesToManagedData(Object updates) { | ||
| if (updates instanceof List) { | ||
| final List<Map<String, Object>> models = (List<Map<String, Object>>) updates; | ||
| for (final Map<String, Object> model : models) { | ||
| addModelFromMap(model); | ||
| } | ||
| } | ||
| if (updates instanceof Map) { | ||
| addModelFromMap((Map<String, Object>) updates); | ||
| } | ||
| return modelsAsManagedResources(store.getModels()); | ||
| } | ||
|
|
||
| @Override | ||
| public void doDeleteChild(BaseSolrResource endpoint, String childId) { | ||
| store.delete(childId); | ||
| storeManagedData(applyUpdatesToManagedData(null)); | ||
| } | ||
|
|
||
| @Override | ||
| public void doGet(BaseSolrResource endpoint, String childId) { | ||
| final SolrQueryResponse response = endpoint.getSolrResponse(); | ||
| response.add(MODELS_JSON_FIELD, modelsAsManagedResources(store.getModels())); | ||
| } | ||
|
|
||
| public M getModel(String modelName) { | ||
| return store.getModel(modelName); | ||
| } | ||
|
|
||
| private static List<Object> modelsAsManagedResources(List<? extends SolrLanguageModel> models) { | ||
| return models.stream().map(ManagedModelStore::toModelMap).collect(Collectors.toList()); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return getClass().getSimpleName() + " [store=" + store + "]"; | ||
| } | ||
| } | ||
19 changes: 19 additions & 0 deletions
19
...ules/language-models/src/java/org/apache/solr/languagemodels/store/rest/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** Contains model store related classes. */ | ||
|
nicolo-rinaldi marked this conversation as resolved.
Outdated
|
||
| package org.apache.solr.languagemodels.store.rest; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.